Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate passing None to DAGCircuit appenders #10752

Merged
merged 3 commits into from
Oct 18, 2023

Commits on Aug 31, 2023

  1. Deprecate passing None to DAGCircuit appenders

    This has been against the documented typing of the functions for some
    time, but some scheduling methods have mistakenly been passing `None`.
    There is no need to support `None` here; the empty tuple `()` is equally
    immutable and a CPython singleton, so there are neither mutability nor
    memory benefits to supporting both, and removing `None` as an input is a
    simple way to remove a(n admittedly cheap) branch from the appender
    methods.
    jakelishman committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    f14012e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    7502f16 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    3a2b5af View commit details
    Browse the repository at this point in the history