Deprecate passing None to DAGCircuit appenders
#10752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been against the documented typing of the functions for some time, but some scheduling methods have mistakenly been passing `None`. There is no need to support `None` here; the empty tuple `()` is equally immutable and a CPython singleton, so there are neither mutability nor memory benefits to supporting both, and removing `None` as an input is a simple way to remove a(n admittedly cheap) branch from the appender methods.
jakelishman
added
the
Changelog: Deprecation
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6039053966
💛 - Coveralls |
1ucian0
reviewed
Oct 16, 2023
1ucian0
previously approved these changes
Oct 16, 2023
jakelishman
force-pushed
the
dag-deprecate-none-args
branch
from
9611b77
to
7502f16
Compare
|
That latest merge commit didn't quite work right - I've just forced pushed a fixed merge commit in 7502f16. |
1ucian0
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This has been against the documented typing of the functions for some time, but some scheduling methods have mistakenly been passing
None. There is no need to supportNonehere; the empty tuple()is equally immutable and a CPython singleton, so there are neither mutability nor memory benefits to supporting both, and removingNoneas an input is a simple way to remove a(n admittedly cheap) branch from the appender methods.Details and comments
I also made Qiskit/qiskit-ibm-provider#721 to fix the same mistake that the IBM Provider inherited from Terra.