Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling backend.name() for backendV2 #11065

Merged
merged 6 commits into from
Oct 21, 2023

Conversation

doichanj
Copy link
Contributor

Summary

In utils/backend_utils.py we have to check backend's version if we call name() function for V1 and get property name for V2, but calling name() function without checking version

Details and comments

This issue causes Neko test error in Qiskit Aer if we upgrade backend from V1 to V2 and we can not release Qiskit Aer without this fix.

@doichanj doichanj requested review from woodsp-ibm and a team as code owners October 20, 2023 09:55
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@mtreinish mtreinish added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Oct 20, 2023
@mtreinish mtreinish added this to the 0.25.3 milestone Oct 20, 2023
@coveralls
Copy link

coveralls commented Oct 20, 2023

Pull Request Test Coverage Report for Build 6594223283

  • 7 of 9 (77.78%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 86.901%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/utils/backend_utils.py 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 1 91.67%
crates/qasm2/src/parse.rs 6 97.6%
Totals Coverage Status
Change from base Build 6591149729: 0.01%
Covered Lines: 73876
Relevant Lines: 85012

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM. It's a bad assumption that the QuantumInstance had aer hardcoded as always using backendv1. This should fix it, I just left a small suggestions inline

qiskit/utils/backend_utils.py Outdated Show resolved Hide resolved
releasenotes/notes/fix_backend_name-e84661707058b529.yaml Outdated Show resolved Hide resolved
doichanj and others added 3 commits October 21, 2023 09:58
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@mtreinish mtreinish added this pull request to the merge queue Oct 21, 2023
Merged via the queue into Qiskit:main with commit d781dcc Oct 21, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Oct 21, 2023
* add check for backend version to get backend name

* move backend_interface_version

* check backend is None before get version

* Update qiskit/utils/backend_utils.py

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit d781dcc)
github-merge-queue bot pushed a commit that referenced this pull request Oct 21, 2023
* add check for backend version to get backend name

* move backend_interface_version

* check backend is None before get version

* Update qiskit/utils/backend_utils.py

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit d781dcc)

Co-authored-by: Jun Doi <doichan@jp.ibm.com>
mtreinish pushed a commit to mtreinish/qiskit-core that referenced this pull request Oct 23, 2023
* add check for backend version to get backend name

* move backend_interface_version

* check backend is None before get version

* Update qiskit/utils/backend_utils.py

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit d781dcc)

Co-authored-by: Jun Doi <doichan@jp.ibm.com>
(cherry picked from commit 2f76ef0)
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2023
* add check for backend version to get backend name

* move backend_interface_version

* check backend is None before get version

* Update qiskit/utils/backend_utils.py

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit d781dcc)

Co-authored-by: Jun Doi <doichan@jp.ibm.com>
(cherry picked from commit 2f76ef0)

Co-authored-by: Jun Doi <doichan@jp.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants