Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling backend.name() for backendV2 (backport #11065) #11076

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 21, 2023

This is an automatic backport of pull request #11065 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* add check for backend version to get backend name

* move backend_interface_version

* check backend is None before get version

* Update qiskit/utils/backend_utils.py

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit d781dcc)
@mergify mergify bot requested review from woodsp-ibm and a team as code owners October 21, 2023 03:15
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Oct 21, 2023
@github-actions github-actions bot added this to the 0.25.3 milestone Oct 21, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6594939424

  • 7 of 9 (77.78%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 86.899%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/utils/backend_utils.py 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 91.41%
crates/qasm2/src/parse.rs 6 97.6%
Totals Coverage Status
Change from base Build 6592101815: -0.01%
Covered Lines: 73872
Relevant Lines: 85009

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Oct 21, 2023
@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Oct 21, 2023
Merged via the queue into stable/0.45 with commit 2f76ef0 Oct 21, 2023
16 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.45/pr-11065 branch October 21, 2023 10:07
mtreinish pushed a commit to mtreinish/qiskit-core that referenced this pull request Oct 23, 2023
* add check for backend version to get backend name

* move backend_interface_version

* check backend is None before get version

* Update qiskit/utils/backend_utils.py

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit d781dcc)

Co-authored-by: Jun Doi <doichan@jp.ibm.com>
(cherry picked from commit 2f76ef0)
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2023
* add check for backend version to get backend name

* move backend_interface_version

* check backend is None before get version

* Update qiskit/utils/backend_utils.py

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit d781dcc)

Co-authored-by: Jun Doi <doichan@jp.ibm.com>
(cherry picked from commit 2f76ef0)

Co-authored-by: Jun Doi <doichan@jp.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants