Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the deprecated code since 0.23 #11167

Closed
wants to merge 1 commit into from

Conversation

neet-14
Copy link
Contributor

@neet-14 neet-14 commented Nov 1, 2023

Summary

Fixes #11145
Changelog: Removal

Details and comments

  • Removed the interp1d, step_wise functions from qiskit/visualization/pulse/interpolation.py and also removed relevant tests.
  • Added a release note.

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Nov 1, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2023

CLA assistant check
All committers have signed the CLA.

@neet-14 neet-14 marked this pull request as ready for review November 2, 2023 09:12
@neet-14 neet-14 requested review from nonhermitian and a team as code owners November 2, 2023 09:12
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6720102596

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 86.918%

Files with Coverage Reduction New Missed Lines %
qiskit/visualization/pulse/matplotlib.py 2 0.0%
crates/qasm2/src/lex.rs 3 91.16%
qiskit/pulse/library/waveform.py 3 93.75%
Totals Coverage Status
Change from base Build 6718708201: 0.02%
Covered Lines: 74014
Relevant Lines: 85154

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your attempt at this contribution. Please see my comment on #11188 (review) regarding this PR.

@ElePT
Copy link
Contributor

ElePT commented Nov 21, 2023

Closing this PR in favor of #11213

@ElePT ElePT closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove deprecated code since 0.23 in qiskit/visualization/pulse/interpolation.py
5 participants