Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the deprecated code since 0.23 (qiskit.visualization.pulse) #11213

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

neet-14
Copy link
Contributor

@neet-14 neet-14 commented Nov 7, 2023

Summary

fixes issue #11144, #11145, #11146

Details and comments

Deleted qiskit.visualization.pulse folder, removed all the references of the class declared in the pulse folder and added a release note.
@1ucian0
@ElePT

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Nov 7, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6942519686

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 714 unchanged lines in 59 files lost coverage.
  • Overall coverage decreased (-0.5%) to 86.403%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/sabre_layout.rs 1 98.31%
crates/accelerate/src/sabre_swap/mod.rs 1 97.35%
crates/accelerate/src/stochastic_swap.rs 1 87.96%
crates/qasm2/src/error.rs 1 97.56%
crates/qasm2/src/lex.rs 1 92.17%
qiskit/circuit/library/evolved_operator_ansatz.py 1 85.12%
qiskit/circuit/library/generalized_gates/unitary.py 1 92.11%
qiskit/converters/circuit_to_instruction.py 1 97.67%
qiskit/opflow/state_fns/operator_state_fn.py 1 80.22%
qiskit/opflow/state_fns/state_fn.py 1 81.88%
Totals Coverage Status
Change from base Build 6774672560: -0.5%
Covered Lines: 66315
Relevant Lines: 76751

💛 - Coveralls

…0ff1a69df63.yaml

Co-authored-by: Raghav <83136390+Raghav-Bell@users.noreply.github.com>
@ElePT ElePT changed the title removed the deprecated code since 0.23 removed the deprecated code since 0.23 (qiskit.visualization.pulse) Nov 21, 2023
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just added a small formatting suggestion for the release note.

@ElePT ElePT added the Changelog: Removal Include in the Removed section of the changelog label Nov 21, 2023
@ElePT ElePT added this to the 1.0.0 milestone Nov 21, 2023
ElePT
ElePT previously approved these changes Nov 21, 2023
@ElePT ElePT added this pull request to the merge queue Nov 21, 2023
Merged via the queue into Qiskit:main with commit 8c7af8d Nov 21, 2023
14 checks passed
FabianBrings pushed a commit to FabianBrings/qiskit that referenced this pull request Nov 27, 2023
…`) (Qiskit#11213)

* removed the deprecated code

* fixed lint and docs

* Update releasenotes/notes/remove-deprecated-visualization-pulse-8adf40ff1a69df63.yaml

Co-authored-by: Raghav <83136390+Raghav-Bell@users.noreply.github.com>

* Update releasenotes/notes/remove-deprecated-visualization-pulse-8adf40ff1a69df63.yaml

* Fix reno

* Fix reno

---------

Co-authored-by: Raghav <83136390+Raghav-Bell@users.noreply.github.com>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants