Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expire deprecation on qargs=None in DAG appends #11190

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Expire deprecation on qargs=None in DAG appends #11190

merged 1 commit into from
Nov 6, 2023

Conversation

jakelishman
Copy link
Member

Summary

This removes the warnings converting explicit Nones into empty tuples, following its deprecation in 0.45.

Details and comments

Originally deprecated in #10752.

@jakelishman
Expire deprecation on qargs=None in DAG appends
018f1d3 
This removes the warnings converting explicit `None`s into empty tuples,
following its deprecation in 0.45.
@jakelishman jakelishman added the Changelog: Removal Include in the Removed section of the changelog label Nov 3, 2023
@jakelishman jakelishman added this to the 1.0.0pre1 milestone Nov 3, 2023
@jakelishman jakelishman requested a review from a team as a code owner November 3, 2023 13:16
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6745686340

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 86.952%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 91.92%
qiskit/pulse/library/waveform.py 3 93.75%
Totals Coverage Status
Change from base Build 6745236401: 0.02%
Covered Lines: 74363
Relevant Lines: 85522
💛 - Coveralls

ElePT
ElePT approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal LGTM.

@ElePT ElePT added this pull request to the merge queue Nov 6, 2023
Merged via the queue into Qiskit:main with commit 81e5ddd Nov 6, 2023
14 checks passed
matthewscottconroy pushed a commit to matthewscottconroy/qiskit that referenced this pull request Nov 6, 2023
@jakelishman @matthewscottconroy
Expire deprecation on qargs=None in DAG appends (Qiskit#11190)
ec5615e 
This removes the warnings converting explicit `None`s into empty tuples,
following its deprecation in 0.45.
matthewscottconroy pushed a commit to matthewscottconroy/qiskit that referenced this pull request Nov 6, 2023
@jakelishman @matthewscottconroy
Expire deprecation on qargs=None in DAG appends (Qiskit#11190)
14728cf 
This removes the warnings converting explicit `None`s into empty tuples,
following its deprecation in 0.45.
@jakelishman jakelishman deleted the remove-dag-warns branch November 6, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
1.0.0b1
Development

Successfully merging this pull request may close these issues.
4 participants
@jakelishman @qiskit-bot @coveralls @ElePT