Pin rust compiler version to 1.73 for wheel builds #11267
Conversation
With the release 1.74 on 11-16-2023 the minimum supported macOS version by the Rust compiler is 10.12. For the 0.45.x release series we still support macOS 10.9 (this will change in 1.0 see Qiskit#10902). To faciliate still publishing wheels that will support macOS 10.9 for any future bugfix releases on 0.45.x release series (and 0.46.x too) this commit pins the rust toolchain version we use to 1.73 which is the last release that support 10.9.
mtreinish
added
type: qa
|
One or more of the the following people are requested to review this:
|
mtreinish
added
the
Rust
mtreinish
force-pushed
the
pin-rust-on-stable
branch
from
de93cf7
to
9cbd70f
Compare
|
The macOS job failure is because of a bug in cattrs 23.2.0 which is being fixed upstream. The windows failure is because the i686 target isn't getting installed for win32. I tried adding it explicitly, I'm not sure why it's not getting installed. I'll have to take a look at the settings for the action to see if I'm missing something. |
|
The wheel builds passed and you can see the output here: https://github.com/Qiskit/qiskit/actions/runs/6960696664/job/18940728312 I've reverted the test commit and this should be ready for review now. |
There was a problem hiding this comment.
I'm totally fine with this in principle, just minor implementation questions: we seem to be a shade inconsistent with where we set RUSTUP_TOOLCHAIN, but things all seem to be working, so it doesn't seem like much of a problem. We set RUSTUP_TOOLCHAIN="stable" in the general environment for cibuildwheel, but then override it to 1.73.0 in Linux, though I thought we were leaving the builds with stable for that?
Summary
With the release 1.74 on 11-16-2023 the minimum supported macOS version by the Rust compiler is 10.12. For the 0.45.x release series we still support macOS 10.9 (this will change in 1.0 see #10902). To facilitate still publishing wheels that will support macOS 10.9 for any future bugfix releases on 0.45.x release series (and 0.46.x too) this commit pins the rust toolchain version we use to 1.73 which is the last release that support 10.9.
Details and comments