Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ahash from 0.8.6 to 0.8.11 #12154

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 7, 2024

Bumps ahash from 0.8.6 to 0.8.11.

Release notes

Sourced from ahash's releases.

v0.8.11

Patch release to further strengthen u64 fastpath based on #210

Full Changelog: tkaitchuck/aHash@v0.8.10...v0.8.11

v0.8.10

Patch to fix #210 which caused poor distribution when hashing a single u64 on nightly.

Full Changelog: tkaitchuck/aHash@v0.8.9...v0.8.10

v0.8.9

Minor patch to fix #207

Full Changelog: tkaitchuck/aHash@v0.8.8...v0.8.9

v0.8.8

What's Changed

New Contributors

Full Changelog: tkaitchuck/aHash@0.8.7...v0.8.8

Version 0.8.7

What's Changed

New Contributors

Full Changelog: tkaitchuck/aHash@v0.8.5...0.8.7

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ahash](https://github.com/tkaitchuck/ahash) from 0.8.6 to 0.8.11.
- [Release notes](https://github.com/tkaitchuck/ahash/releases)
- [Commits](https://github.com/tkaitchuck/ahash/commits/v0.8.11)

---
updated-dependencies:
- dependency-name: ahash
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner April 7, 2024 16:34
@dependabot dependabot bot added Changelog: None Do not include in changelog dependencies Pull requests that update a dependency file Rust This PR or issue is related to Rust code in the repository labels Apr 7, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@jakelishman
Copy link
Member

jakelishman commented Apr 7, 2024

Okey dokey, after some dancing on the bottom of #11510, this should have been a successful way of cancelling the "ignore" command we issued to dependabot, since ahash did apparently decide to roll back the huge MSRV bump eventually. I'm still nervous because as a project, ahash does not appear to be very concerned with stability guarantees (see the response to #216, and how the huge bump to MSRV 1.72 from 1.60 was considered eligible for a patch release), but hopefully this is good enough for now.

We need updated ahash to get Miri working. I'll push a test wheel-build commit to trial this.

@jakelishman
Copy link
Member

Whoops, I removed the deployment bit but forgot to remove the environment request.

@jakelishman jakelishman force-pushed the dependabot/cargo/ahash-0.8.11 branch from 7f8a6ce to c8beda5 Compare April 7, 2024 16:46
@coveralls
Copy link

coveralls commented Apr 7, 2024

Pull Request Test Coverage Report for Build 8597314613

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.384%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.86%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 8597261255: 0.02%
Covered Lines: 60305
Relevant Lines: 67467

💛 - Coveralls

@jakelishman jakelishman force-pushed the dependabot/cargo/ahash-0.8.11 branch 2 times, most recently from 5bcd8aa to 1197e3a Compare April 8, 2024 08:00
@jakelishman jakelishman force-pushed the dependabot/cargo/ahash-0.8.11 branch from 1197e3a to 61b473b Compare April 8, 2024 08:55
@jakelishman
Copy link
Member

jakelishman commented Apr 8, 2024

Ok, https://github.com/Qiskit/qiskit/actions/runs/8596576569/job/23553439088?pr=12154 shows a complete wheel-build run (including dummy commit 1197e3a) for all relevant targets ignoring the win32 fail - it's got the same trouble encountered in #11267 when setting rustc to 1.70, but I can't be bothered to debug that since it's irrelevant to our CD. The important thing is that Linux AArch64 passed.

With that in place, I'll merge this and we should be safe to continue upgrading aHash (until the next time they decide to make a huge MSRV jump in a patch release).

@jakelishman jakelishman removed the on hold Can not fix yet label Apr 8, 2024
@jakelishman jakelishman added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 9ed963f Apr 8, 2024
14 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/ahash-0.8.11 branch April 8, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog dependencies Pull requests that update a dependency file Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants