Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove qiskit.visualization.pulse module #11286

Closed
wants to merge 1 commit into from

Conversation

gluonhiggs
Copy link
Contributor

Summary

fixes #11146

Details and comments

  • Removed qiskit.visualization.pulse module
  • Removed redundant code related to the qiskit.visualization.pulse module in qiskit/pulse/instructions/instruction.py
  • Added release note

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Nov 21, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gluonhiggs gluonhiggs changed the title resolve issue #11146 resolve issue #11146 label:"Changelog: Removal" Nov 21, 2023
@gluonhiggs gluonhiggs changed the title resolve issue #11146 label:"Changelog: Removal" remove qiskit.visualization.pulse module Nov 21, 2023
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @gluonhiggs, unfortunately we already have an open community PR that addresses this removal: #11213.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6940609058

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 86.417%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 91.92%
crates/qasm2/src/parse.rs 6 97.6%
Totals Coverage Status
Change from base Build 6936902897: 0.5%
Covered Lines: 66326
Relevant Lines: 76751

💛 - Coveralls

@ElePT
Copy link
Contributor

ElePT commented Nov 22, 2023

Closing for the reasons mentioned above, as ##11213 has been merged.

@ElePT ElePT closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove deprecated code since 0.23 in qiskit/visualization/pulse/qcstyle.py
5 participants