Invalidate parameters cache on circuit copy
#12619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the caching of the parameter view could persist between copies of the circuit because it was part of the `copy.copy`.
jakelishman
added
Changelog: Bugfix
|
One or more of the following people are relevant to this code:
|
jakelishman
added
the
stable backport potential
Cryoris
approved these changes
Jun 20, 2024
|
@Mergifyio backport stable/0.46 stable/1.1 |
✅ Backports have been created
|
Pull Request Test Coverage Report for Build 9600462226Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Previously, the caching of the parameter view could persist between copies of the circuit because it was part of the `copy.copy`. (cherry picked from commit b6c6166) # Conflicts: # qiskit/circuit/quantumcircuit.py # test/python/circuit/test_parameters.py
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Previously, the caching of the parameter view could persist between copies of the circuit because it was part of the `copy.copy`. (cherry picked from commit b6c6166) # Conflicts: # qiskit/circuit/quantumcircuit.py
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Invalidate `parameters` cache on circuit copy (#12619) Previously, the caching of the parameter view could persist between copies of the circuit because it was part of the `copy.copy`. (cherry picked from commit b6c6166) # Conflicts: # qiskit/circuit/quantumcircuit.py * Fix conflict --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Invalidate `parameters` cache on circuit copy (#12619) Previously, the caching of the parameter view could persist between copies of the circuit because it was part of the `copy.copy`. (cherry picked from commit b6c6166) # Conflicts: # qiskit/circuit/quantumcircuit.py # test/python/circuit/test_parameters.py * Fix conflict * Fix conflict in test * Update test/python/circuit/test_parameters.py --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
Previously, the caching of the parameter view could persist between copies of the circuit because it was part of the `copy.copy`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the caching of the parameter view could persist between copies of the circuit because it was part of the
copy.copy.Details and comments
Fix #12617.
I verified that this is present in 1.1.0 as well.