PassManager controller: "best of" #3018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ucian0
requested review from
ajavadia,
atilag,
chriseclectic,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
lcapelluto,
mtreinish,
nonhermitian and
taalexander
as code owners
added 2 commits
August 21, 2019 14:25
|
Can you make this fix #2845 as a test of its functionality? |
|
Sure separate PR is fine but it would be good to build on this so we can see how it all works for a concrete use case.
… On Sep 12, 2019, at 9:26 AM, Luciano ***@***.***> wrote:
Can you make this fix #2845 as a test of its functionality?
I would prefer to do it in a different PR to keep this one small and functionally independently.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This was referenced Jan 27, 2021
|
stalled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2969
This PR introduced a PassManager controllerReplaces with torollback_if. If the condition isTrue, the passes appended in that set, will be "rolled back". This will allow us to implement "best of" selections for situation like layout selection, or to choose the best swapper.BestOf. See #3018 (comment)