Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passmanager.append(flowcontroller) instead of passes #5772

Merged
merged 8 commits into from
Feb 10, 2021
Merged

Allow passmanager.append(flowcontroller) instead of passes #5772

merged 8 commits into from
Feb 10, 2021

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Feb 2, 2021

As part of adding support for a BestOf pass manager flow controller, @kdk suggested the possibility of adding flow controllers to a pass manager.

I think that makes total sense.

@1ucian0 1ucian0 requested a review from a team as a code owner February 2, 2021 14:35
@kdk kdk added this to the 0.17 milestone Feb 4, 2021
@kdk kdk added the Changelog: New Feature Include in the "Added" section of the changelog label Feb 4, 2021
kdk
kdk reviewed Feb 4, 2021
View reviewed changes
Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Can you update the relevant docstrings to point out that a FlowController is now allowed?

qiskit/transpiler/runningpassmanager.py Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kdk kdk added the automerge label Feb 10, 2021
@mergify mergify bot merged commit b95ade1 into Qiskit:master Feb 10, 2021
@1ucian0 1ucian0 mentioned this pull request Feb 17, 2021
Closed
@1ucian0 1ucian0 mentioned this pull request Aug 24, 2021
Closed
@jlapeyre jlapeyre mentioned this pull request Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdk kdk kdk approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
3 participants
@1ucian0 @CLAassistant @kdk