Deprecate circuit.combine and circuit.extend #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajavadia
requested review from
1ucian0,
chriseclectic,
ewinston,
jaygambetta,
kdk,
maddy-tod and
mtreinish
as code owners
ajavadia
requested review from
DanPuzzuoli,
eggerdj,
itoko,
jyu00,
lcapelluto,
nkanazawa1989,
nonhermitian and
taalexander
as code owners
|
Is this 0.15? |
kdk
reviewed
Jun 30, 2020
|
|
…a/qiskit-terra into deprecate-circuit-combine-extend
kdk
added
the
Changelog: Deprecation
kdk
reviewed
Feb 19, 2021
releasenotes/notes/deprecate-circuit-combine-extend-ffc6a073ed114890.yaml
Show resolved
Hide resolved
3 tasks
MarkoShiva
reviewed
Mar 2, 2021
MarkoShiva
reviewed
Mar 2, 2021
kdk
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
circuit.compose()covers all the functionality provided bycircuit.combine/extend, and is more flexible. The only thing it doesn't do is handle cases where the RHS has extra registers. The only usecase I've seen for this is composing a circuit with another measurement circuit (which has extra creg). But I think this case is better handled by circuit.measure_all().