This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Avoid using circuit.extend and combine #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
levbishop,
manoelmarques,
pbark and
woodsp-ibm
as code owners
|
@Cryoris What is the status of the work on this |
|
I think I missed some occurrences, it needs a bit more time invested! |
|
Reference to PR in Terra to deprecate extend & combine Qiskit/qiskit#4208 |
|
@Cryoris Any thoughts on this - since we are now emitting deprecation warnings in this regard it might be good to add any places that are not fixed and get this merged - I have not looked at the algos that are now moved to Terra - did anything there need updating or was that already done? |
|
Yeah it would be good to get this in, now that these two commands are deprecated. The algos in Terra are already updated accordingly. |
manoelmarques
previously approved these changes
Mar 29, 2021
Cryoris
changed the title
manoelmarques
approved these changes
Mar 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The register based methods
QuantumCircuit.extendandcombineare to be deprecated. Instead, we can just useappendorcompose(ortensor, which is to be added but I don't think it's necessary in the use-cases in Aqua).Details and comments
WIP because
reno missingmaybe a reno is not necessary, since this is not a user facing change