Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Furo: fix spacing of chevrons in left table of contents #411

Closed
Eric-Arellano opened this issue Jun 22, 2023 · 0 comments · Fixed by #421
Closed

Furo: fix spacing of chevrons in left table of contents #411

Eric-Arellano opened this issue Jun 22, 2023 · 0 comments · Fixed by #421
Assignees
@Eric-Arellano
Milestone
Furo 1.0

Comments

@Eric-Arellano
Copy link
Collaborator

The icon is too close to the right. Probabaly we want left and right to be aligned.

Screenshot 2023-06-22 at 10 20 24 AM
@Eric-Arellano Eric-Arellano added this to the Furo 1.0 milestone Jun 22, 2023
@Eric-Arellano Eric-Arellano self-assigned this Jun 22, 2023
@Eric-Arellano Eric-Arellano mentioned this issue Jun 27, 2023
Merged
Eric-Arellano added a commit that referenced this issue Jun 28, 2023
@Eric-Arellano
Revert adding more padding to Furo table of contents (#421)
617dd77 
I thought that this was a good idea because we intentionally make the
left sidebar overall bigger.

But I realized when looking at the Qiskit Experiments docs that we have
a lot of API page titles, and those tend to have long names.

![Screenshot 2023-06-27 at 12 26 48
PM](https://github.com/Qiskit/qiskit_sphinx_theme/assets/14852634/91725369-e121-4f70-babc-fefeb3ea1662)

So, it's better to fully use the screen real estate and use Furo's
default padding rules, which IMO are sufficient.

We were also diverging from IBM Quantum, which uses 16 pixels of
padding.

Finally, this avoids weirdness with the right chevrons not having enough
padding. Closes
#411.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eric-Arellano Eric-Arellano

Labels
None yet
Projects
None yet
Milestone
Furo 1.0
Development

Successfully merging a pull request may close this issue.

Revert adding more padding to Furo table of contents Qiskit/qiskit_sphinx_theme
1 participant
@Eric-Arellano