Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert adding more padding to Furo table of contents #421

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Jun 27, 2023

I thought that this was a good idea because we intentionally make the left sidebar overall bigger.

But I realized when looking at the Qiskit Experiments docs that we have a lot of API page titles, and those tend to have long names.

Screenshot 2023-06-27 at 12 26 48 PM

So, it's better to fully use the screen real estate and use Furo's default padding rules, which IMO are sufficient.

We were also diverging from IBM Quantum, which uses 16 pixels of padding.

Finally, this avoids weirdness with the right chevrons not having enough padding. Closes #411.

Copy link
Collaborator

@coruscating coruscating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the Experiments docs look better now :)

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a bit unsure about the padding on the right of the chevrons, but let's keep it like this for now and we can revisit it later if it becomes an issue 🚀

@Eric-Arellano Eric-Arellano merged commit 617dd77 into main Jun 28, 2023
3 of 4 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/left-chevron branch June 28, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Furo: fix spacing of chevrons in left table of contents
3 participants