Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot tests for announcement banner #533

Closed
javabster opened this issue Aug 10, 2023 · 0 comments · Fixed by #561
Closed

Add snapshot tests for announcement banner #533

javabster opened this issue Aug 10, 2023 · 0 comments · Fixed by #561

Comments

@javabster
Copy link
Collaborator

javabster commented Aug 10, 2023 •
edited
Loading

#530 added an announcement banner for the main qiskit theme. We should add some snapshot tests to cover this new feature
@javabster javabster mentioned this issue Aug 10, 2023
Merged
5 tasks
@Eric-Arellano Eric-Arellano mentioned this issue Aug 28, 2023
Merged
Eric-Arellano added a commit that referenced this issue Aug 30, 2023
@Eric-Arellano
Add snapshot tests for announcement banner (#561)
2f95f33 
Closes #533 and
#529. The original
issue was the selector was missing a `.` to indicate that
`custom-announcement` is a class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Qiskit Sphinx Theme
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add snapshot tests for announcement banner Eric-Arellano/qiskit_sphinx_theme
1 participant
@javabster