Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot tests for announcement banner #561

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add snapshot tests for announcement banner #561

merged 1 commit into from
Aug 30, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

Closes #533 and #529. The original issue was the selector was missing a . to indicate that custom-announcement is a class.

frankharkins
frankharkins approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The extra explanation is good too

@Eric-Arellano Eric-Arellano merged commit 2f95f33 into Qiskit:main Aug 30, 2023
5 checks passed
@Eric-Arellano Eric-Arellano mentioned this pull request Aug 30, 2023
Closed
@Eric-Arellano Eric-Arellano deleted the banner-tests branch December 1, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankharkins frankharkins frankharkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add snapshot tests for announcement banner
2 participants
@Eric-Arellano @frankharkins