-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back next and previous buttons to footer #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the old footer.html
, it has theme_prev_next_buttons_location
environment variable to specify the location. breadcrumb.html
still has such logic to show on the top. Do you want add the condtion back?
A quick check, the meta doc and nature doc sets `'prev_next_buttons_location': 'bottom'
So practically remove the conditions won't change anything, but I think we can simply revert it back to the old version and let individual repo to decide where to put the button. |
I can't see that variable being used anywhere from the qiskit repo side, i think it's used to specify where on the page the buttons are located so I don't think we need them as (I assume) we always want the buttons to be placed at the bottom of the page. Also I have an open issue for cleaning up the breadcrumbs file, it was one of the few I didn't get round to cleaning up before the last big release we did |
It's used at least for qiskit meta and qiskit-nature, probably other repos too. |
I tested building using Source: html.zip And a quick search on the qiskit github org, all repos that uses |
In an earlier version of the theme we removed the "Next" and "Previous" buttons in the footer. In response to user requests and further discussion we have decided to add that component back.
fixes #174
In this PR: