Experiment with determining GitHub branch name - PR build #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use GitHub branch protection to require opening a PR for `main` and the `1.*` branches; you cannot push directly. For `main`, we also require that CI runs against the latest `main`. So, there is no need to run CI again for pushes since it already runs with PRs. Don't waste compute resources, which have a real environmental cost.
This PR changes the wheel-build job to publish the package to PyPI with the trusted publisher mechanism following the steps in https://docs.pypi.org/trusted-publishers/using-a-publisher/ and https://github.com/Qiskit/rustworkx/pull/1001/files
Closes #571. Thanks to @arnaucasau, no projects are actively using the old Pytorch theme 🎉 A follow up will also remove the `qiskit` theme so that we only have `qiskit-ecosystem`.
Qiskit documentation now lives in docs.quantum.ibm.com and has its own analytics mechanism. The Qiskit Ecosystem projects will be migrating to GitHub pages. Qiskit/ecosystem#578. Given that, I doubt we'll want to commit to still maintaining this analytics mechanism. Maintenance is more than only the code: it also means committing to helping projects access the dashboard. Instead, keep this Sphinx theme as simple as possible to make it more sustainable. Projects highly interested in analytics could always add the functionality their own way.
The Qiskit theme is being removed and we'll only have qiskit-ecosystem, per #577. The qiskit-ecosystem theme never supported these custom announcements from #530 - so this current code adds unnecessary noise. If we decide we do want this custom announcement feature for the Ecosystem, we can always add this code back easily thanks to Git. In the meantime, the focus is on making this codebase as small and sustainable as possible.
Part of #577. This is great because it allows us to remove the custom web components mechanism. We could always add that back in the future if necessary, but it does add a lot of complexity. So removing it makes this repo more sustainable. We can also remove needing to replace `furo.js` with `qiskit-sphinx-theme.js`.
Part of #577. We used to have a custom mobile header for the Qiskit theme to account for the Qiskit.org top nav bar. The Ecosystem theme meanwhile reverted to the default Furo header. We now always use the default Furo header. This also reverts a change to the placeholder text in the search box to mention the project name. That was to make more clear that search was only for Qiskit docs and not all of qiskit.org. That's not relevant now.
The two themes are now equivalent and there is no longer an `/ecosystem` folder with overrides. A follow up PR will remove the `qiskit` theme. ## Removes blue color code This was only used for IBM Provider and IBM Runtime, which both now live at docs.quantum.ibm.com. We never wanted other projects to use the color scheme. Technically projects can still override their color by changing `conf.py`, since Furo itself allows that. But we don't advertise it for now.
The guides are no longer live.
We no longer use Pytorch in this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.