Remove invalid flag for coverage job #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coverage job requires setting the -Zno-landing-pads flag, however on the current version of rust nightly this flag has been removed (see: rust-lang/rust#70175) and the job is no longer working. This commit works around this by removing the flag to fix the job (see mozilla/grcov#427 for more details).
mtreinish
added a commit
to mtreinish/retworkx
that referenced
this pull request
Jul 13, 2020
This commit updates the flags used for generating coverage data with grcov based on the latest README for grcov. [1] The last time these were updated in Qiskit#72 was to remove a flag that was being removed from rust and causing the job to fail. However, that commit failed to add equivalent flags which would perform the same functionality. This commit fixes that oversight so we should have more reliable coverage collection. [1] https://github.com/mozilla/grcov/blob/master/README.md
mtreinish
added a commit
that referenced
this pull request
Jul 13, 2020
This commit updates the flags used for generating coverage data with grcov based on the latest README for grcov. [1] The last time these were updated in #72 was to remove a flag that was being removed from rust and causing the job to fail. However, that commit failed to add equivalent flags which would perform the same functionality. This commit fixes that oversight so we should have more reliable coverage collection. [1] https://github.com/mozilla/grcov/blob/master/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage job requires setting the -Zno-landing-pads flag, however on
the current version of rust nightly this flag has been removed (see:
rust-lang/rust#70175) and the job is no longer working. This commit works
around this by removing the flag to fix the job (see mozilla/grcov#427
for more details).