Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: Command line example does not work with rustc nightly 2020-04-30 #427

Closed
gifnksm opened this issue May 1, 2020 · 10 comments · Fixed by #428
Closed

README.md: Command line example does not work with rustc nightly 2020-04-30 #427

gifnksm opened this issue May 1, 2020 · 10 comments · Fixed by #428

Comments

@gifnksm
Copy link

gifnksm commented May 1, 2020

The following command line option no longer works with rustc nightly due to the removal of the -Zno-landing-pads option (rust-lang/rust#70175)

export CARGO_INCREMENTAL=0
export RUSTFLAGS="-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zno-landing-pads"
@Minoru Minoru mentioned this issue May 1, 2020
Closed
rivy added a commit to rivy/rs.coreutils that referenced this issue May 1, 2020
@rivy
maint/CICD ~ fix coverage build failures by pinning to known-working …
88a700e 
…nightly toolchain

## [why]

Code coverage must currently use some unstable features in nightly rust builds. The
nightly builds are, by definition, unstable and subject to frequent breaking changes.
To prevent CI build breakage, the toolchain is pinned to a specific known working set.

Note: (maint!) this will require periodic review until code coverage is more fully
implemented/integrated into Rust and moved into the stable channel.

- refs: <mozilla/grcov#427>, <newsboat/newsboat#916>
rivy added a commit to rivy/rs.coreutils that referenced this issue May 1, 2020
@rivy
maint/CICD ~ fix coverage build failures by pinning to known-working …
2040c26 
…nightly toolchain

## [why]

Code coverage must currently use some unstable features in nightly rust builds. The
nightly builds are, by definition, unstable and subject to frequent breaking changes.
To prevent CI build breakage, the toolchain is pinned to a specific known working set.

Note: (maint!) this will require periodic review until code coverage is more fully
implemented/integrated into Rust and moved into the stable channel.

- refs: <mozilla/grcov#427>, <newsboat/newsboat#916>
rivy added a commit to rivy/rs.pastel that referenced this issue May 1, 2020
@rivy
Maint/CICD ~ fix coverage build failures by pinning to known-working …
5e92417 
…nightly toolchain

## [why]

Code coverage must currently use some unstable features in nightly rust builds. The
nightly builds are, by definition, unstable and subject to frequent breaking changes.
To prevent CI build breakage, the toolchain is pinned to a specific known working set.

Note: (maint!) this will require periodic review until code coverage is more fully
implemented/integrated into Rust and moved into the stable channel.

- refs: <mozilla/grcov#427>, <newsboat/newsboat#916>
rivy added a commit to rivy/rs.pastel that referenced this issue May 1, 2020
@rivy
Maint/CICD ~ fix coverage build failures by pinning to known-working …
e6be984 
…nightly toolchain

## [why]

Code coverage must currently use some unstable features in nightly rust builds. The
nightly builds are, by definition, unstable and subject to frequent breaking changes.
To prevent CI build breakage, the toolchain is pinned to a specific known working set.

Note: (maint!) this will require periodic review until code coverage is more fully
implemented/integrated into Rust and moved into the stable channel.

- refs: <mozilla/grcov#427>, <newsboat/newsboat#916>
rivy added a commit to rivy/rs.pastel that referenced this issue May 1, 2020
@rivy
Maint/CICD ~ fix coverage build failures by pinning to known-working …
446f83f 
…nightly toolchain

## [why]

Code coverage must currently use some unstable features in nightly rust builds. The
nightly builds are, by definition, unstable and subject to frequent breaking changes.
To prevent CI build breakage, the toolchain is pinned to a specific known working set.

Note: (maint!) this will require periodic review until code coverage is more fully
implemented/integrated into Rust and moved into the stable channel.

- refs: <mozilla/grcov#427>, <newsboat/newsboat#916>
This was referenced May 2, 2020
Merged
Merged
@wusyong
Copy link
Contributor

wusyong commented May 2, 2020 •
edited
Loading

So is it safe if we just remove no-landing-pads? Or we should also add panic=abort?

@wusyong wusyong mentioned this issue May 2, 2020
Merged
rivy added a commit to rivy/rs.pastel that referenced this issue May 2, 2020
@rivy
Maint/CICD ~ fix coverage build failures by pinning to known-working …
231106d 
…nightly toolchain

## [why]

Code coverage must currently use some unstable features in nightly rust builds. The
nightly builds are, by definition, unstable and subject to frequent breaking changes.
To prevent CI build breakage, the toolchain is pinned to a specific known working set.

Note: (maint!) this will require periodic review until code coverage is more fully
implemented/integrated into Rust and moved into the stable channel.

- refs: <mozilla/grcov#427>, <newsboat/newsboat#916>
rivy added a commit to rivy/rs.coreutils that referenced this issue May 2, 2020
@rivy
maint/CICD ~ fix coverage build failures by pinning to known-working …
312d9b9 
…nightly toolchain

## [why]

Code coverage must currently use some unstable features in nightly rust builds. The
nightly builds are, by definition, unstable and subject to frequent breaking changes.
To prevent CI build breakage, the toolchain is pinned to a specific known working set.

Note: (maint!) this will require periodic review until code coverage is more fully
implemented/integrated into Rust and moved into the stable channel.

- refs: <mozilla/grcov#427>, <newsboat/newsboat#916>
@kngwyu
Copy link

kngwyu commented May 3, 2020 •
edited
Loading

Hey guys, I also encountered this issue and removed no-landing-pads, resulting in decreased coverage(from 58% to 38%).
https://codecov.io/gh/PyO3/pyo3/branch/master/commits?from=2020-04-28%2000%3A00%3A00&to=2020-05-03%2000%3A00%3A00

Any idea?

@sagebind sagebind mentioned this issue May 3, 2020
Merged
sagebind added a commit to sagebind/isahc that referenced this issue May 3, 2020
@sagebind
Fix code coverage runs (#183)
1f92a04 
`-Zno-landing-pads` was removed from nightly recently (rust-lang/rust#70175), which seems to mess up grcov reports (mozilla/grcov#427). Even after figuring out how to set `panic=abort` on all the correct profiles, it seems that it still reports odd numbers relative to when `-Zno-landing-pads` worked.

Switch to [tarpaulin](https://github.com/xd009642/tarpaulin) for now which has also caught my eye recently.
@calixteman
Copy link
Collaborator

Hey guys, I also encountered this issue and removed no-landing-pads, resulting in decreased coverage(from 58% to 38%).
https://codecov.io/gh/PyO3/pyo3/branch/master/commits?from=2020-04-28%2000%3A00%3A00&to=2020-05-03%2000%3A00%3A00

Any idea?

Quite strange..., could you file a bug and attached a lcov.info file (if possible the one generated in your CI) ?

@calixteman
Copy link
Collaborator

Yep it's safe to remove no-landing-pads.
The only problem that we'll some accuracy...
A partial workaround could be to use the new option --exec-line with pattern "^[ \t]*\}[ \t]*$" to not count lines with only a closing brace (most of the time clean up stuff on stack unwinding is associated with the debug info of the closing element).

@calixteman
Copy link
Collaborator

I just read the rustc patch and it seems that -Cpanic=abort is (for now) just a renaming.
If I missed something please tell me but using this option should be equivalent to no-landing-pads.

mtreinish added a commit to mtreinish/retworkx that referenced this issue May 4, 2020
@mtreinish
Remove invalid flag for coverage job
7dd4b38 
The coverage job requires setting the -Zno-landing-pads flag, however on
the current version of rust nightly this flag has been removed (see:
rust-lang/rust#70175) and the job is no longer working. This commit works
around this by removing the flag to fix the job (see mozilla/grcov#427
for more details).
@mtreinish mtreinish mentioned this issue May 4, 2020
Merged
mtreinish added a commit to Qiskit/rustworkx that referenced this issue May 4, 2020
@mtreinish
Remove invalid flag for coverage job (#72)
df154b4 
The coverage job requires setting the -Zno-landing-pads flag, however on
the current version of rust nightly this flag has been removed (see:
rust-lang/rust#70175) and the job is no longer working. This commit works
around this by removing the flag to fix the job (see mozilla/grcov#427
for more details).
@calixteman
Copy link
Collaborator

I managed to run tests for pyo3 in using -Cpanic=abort -Zpanic_abort_tests in RUSTFLAGS.
The doc tests were failing with that so adding an extra RUSTDOCFLAGS="-Cpanic=abort" fixes failures.

@marco-c marco-c mentioned this issue May 5, 2020
Open
@rivy
Copy link

rivy commented May 5, 2020

So, when fixing the problem by dropping -Zno-landing-pads and adding -Cpanic=abort -Zpanic_abort_tests to RUSTFLAGS and setting RUSTDOCFLAGS="-Cpanic=abort", does coverage drop?

Currently, to avoid problems or code coverage drops, my workaround for uutils/coreutils is pinning the rust version to the last working toolchain (nightly-2020-04-29) for code coverage.

@calixteman
Copy link
Collaborator

@rivy please make a try.
I made the change this afternoon for an other project:
https://codecov.io/gh/calixteman/dump_syms/commits
and it's ok.

@rivy
Copy link

rivy commented May 5, 2020

@calixteman , Ok, will do ...

@kngwyu
Copy link

kngwyu commented May 6, 2020

@calixteman

I managed to run tests for pyo3 in using -Cpanic=abort -Zpanic_abort_tests in RUSTFLAGS.
The doc tests were failing with that so adding an extra RUSTDOCFLAGS="-Cpanic=abort" fixes failures.

Great, thank you for investigating that!

@kngwyu kngwyu mentioned this issue May 6, 2020
Merged
marco-c pushed a commit that referenced this issue May 6, 2020
Remove -Zno-landing-pads flag, use -Cpanic=abort instead (#428)
083b395 
Fixes #427
mklein994 added a commit to mklein994/dynamic_wallpaper that referenced this issue May 9, 2020
@mklein994
ci: Use -Cpanic=abort instead of -Zno-landing-pads
9111213 
`no-landing-pads` was removed from rust nightly.

mozilla/grcov#427 and
rust-lang/rust#70175
sharkdp pushed a commit to sharkdp/pastel that referenced this issue May 24, 2020
@rivy @sharkdp
Maint/CICD ~ fix coverage build failures by pinning to known-working …
a45a7f5 
…nightly toolchain

## [why]

Code coverage must currently use some unstable features in nightly rust builds. The
nightly builds are, by definition, unstable and subject to frequent breaking changes.
To prevent CI build breakage, the toolchain is pinned to a specific known working set.

Note: (maint!) this will require periodic review until code coverage is more fully
implemented/integrated into Rust and moved into the stable channel.

- refs: <mozilla/grcov#427>, <newsboat/newsboat#916>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove -Zno-landing-pads flag wusyong/grcov
5 participants
@rivy @gifnksm @calixteman @wusyong @kngwyu