Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Gitpod to use the Docker image #5

Merged
merged 4 commits into from
May 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
name: Build Gitpod Docker image
runs-on: ubuntu-latest
environment: a11y-dev
if: "github.repository_owner == 'Quansight-Labs' && !contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.event.head_commit.message, '[skip github]')"
if: "github.repository_owner == 'jupyter' && !contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.event.head_commit.message, '[skip github]')"
steps:
- name: Clone repository ⚡
uses: actions/checkout@v3
Expand Down
18 changes: 14 additions & 4 deletions .gitpod.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,29 @@
image:
file: testing/tools/gitpod/Dockerfile
image: quansight/jupyter-a11y:latest

tasks:
- name: Install JupyterLab Node.js testing dependencies
init: |
cd testing/jupyterlab
echo " 📦 Installing node dependencies "
yarn install
cd workspace/a11y
npx playwright install
echo "🚀 Dependencies installed "
cd /workspace/accessibility/
trallard marked this conversation as resolved.
Show resolved Hide resolved

# --------------------------------------------------------
# exposing ports
ports:
- port: 9323
- port: 8888

# some useful extensions to have
vscode:
extensions:
trallard marked this conversation as resolved.
Show resolved Hide resolved
- eamodio.gitlens
- ms-python.python
- yzhang.markdown-all-in-one
- bungcip.better-toml

# --------------------------------------------------------
# using prebuilds for the container
# With this configuration the prebuild will happen on push to master
Expand All @@ -34,6 +44,6 @@ github:
# need to change
addComment: false
# add a "Review in Gitpod" button to the pull request's description (defaults to false)
addBadge: false
addBadge: true
# add a label once the prebuild is ready to pull requests (defaults to false)
addLabel: false
2 changes: 1 addition & 1 deletion testing/jupyterlab/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ by modifying the [`playwright.config.ts`](testing/jupyterlab/playwright.config.t
```

Your console should output a local URL that you can open in your browser to see
the test results: typically http://127.0.0.1:9323
the test results: typically <http://127.0.0.1:9323>

### :cloud: Running in Gitpod

Expand Down
1 change: 0 additions & 1 deletion testing/tools/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ ARG JUPYTER_APP=jupyterlab
# base HOME for all things in gitpod
ENV DEBIAN_FRONTEND=noninteractive
ENV GITPOD_HOME=/home/gitpod \
WORKSPACE=/workspace/a11y \
USER=gitpod \
GITPOD_GIUD=33333

Expand Down