Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Gitpod to use the Docker image #5

Merged
merged 4 commits into from
May 27, 2022
Merged

Conversation

trallard
Copy link
Member

Last step following from #4 - this should make it so that we use the prebuilt image and enables pre-builds for Gitpod

@trallard
Copy link
Member Author

Ran the tests again and now it all works as expected 🎉 - @gabalafou or @tonyfast can you do a sanity check and merge? 🙏🏽

Copy link
Collaborator

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm still seeing an issue when I do the following:

  1. Open PR #5 in Gitpod
  2. cd testing/jupyterlab
  3. yarn test

The issue is that error message we saw before: that we need to run npx playwright install.

Here's a screenshot:

image

.gitpod.yml Show resolved Hide resolved
.gitpod.yml Show resolved Hide resolved
@gabalafou
Copy link
Collaborator

Follow up. If I run npx playwright install then yarn test, it works as I expect: Playwright runs the tests and generates a WCAG violation report for the tests run.

@trallard
Copy link
Member Author

Are you opening Gitpod from master or from this branch? @gabalafou

Not sure if you will be able to access my logs https://gitpod.io/projects/accessibility/83f468d6-33ef-4dfc-9a5c-c092cfe67913 but you can see the pre-build is completing all these installs

@gabalafou
Copy link
Collaborator

gabalafou commented May 27, 2022

I was opening from this branch/PR by going to this URL: https://gitpod.io/#https://github.com/Quansight-Labs/accessibility/pull/5

@gabalafou
Copy link
Collaborator

When I go to the logs url you pasted, all I see is one line:

operation not permitted: missing get permission on workspace

@trallard trallard mentioned this pull request May 27, 2022
@trallard
Copy link
Member Author

I figured...
Prebuild_—_Gitpod

@gabalafou
Copy link
Collaborator

gabalafou commented May 27, 2022

¯\_(ツ)_/¯

It makes no sense. All I can tell you is that when I was playing around with Gitpod, the only way I could get this to work is if I put npx playwright install under command in the .gitpod.yml file. I don't know enough about what's going on under the hood to understand why running that command in init doesn't "stick."

@gabalafou
Copy link
Collaborator

Okay, here's a clue from my command log (pasted below). See how there's nothing in ~/.cache? But after I run npx playwright install the browser folders are put in .cache. My first thought was that maybe Gitpod nukes the .cache folder between the init commands and the point at which it puts you in the shell. But the fact that yarn exists in .cache suggests to me that's not it. Maybe it has something to do with who Gitpod thinks the user is (and hence the home directory path to .cache) when it runs init?

(a11y-tests) gitpod > /workspace/accessibility $ cd testing/jupyterlab/
(a11y-tests) gitpod > /workspace/accessibility/testing/jupyterlab $ ls ~/.cache
yarn
(a11y-tests) gitpod > /workspace/accessibility/testing/jupyterlab $ npx playwright install
Downloading Playwright build of chromium v1000 - 132.8 Mb [====================] 100% 0.0s 
Playwright build of chromium v1000 downloaded to /home/gitpod/.cache/ms-playwright/chromium-1000
Downloading Playwright build of ffmpeg v1007 - 2.6 Mb [====================] 100% 0.0s 
Playwright build of ffmpeg v1007 downloaded to /home/gitpod/.cache/ms-playwright/ffmpeg-1007
Downloading Playwright build of firefox v1322 - 76.3 Mb [====================] 100% 0.0s 
Playwright build of firefox v1322 downloaded to /home/gitpod/.cache/ms-playwright/firefox-1322
Downloading Playwright build of webkit v1630 - 86.6 Mb [====================] 100% 0.0s 
Playwright build of webkit v1630 downloaded to /home/gitpod/.cache/ms-playwright/webkit-1630
(a11y-tests) gitpod > /workspace/accessibility/testing/jupyterlab $ ls ~/.cache
ms-playwright  yarn

@trallard
Copy link
Member Author

Maybe it has something to do with who Gitpod thinks the user is (and hence the home directory path to .cache) when it runs init?

It should not matter unless you are jumping on an already made workspace anywho will merge for now and can improve later - esp if we are merging the other doit branch

@trallard trallard merged commit a572bc9 into master May 27, 2022
@trallard trallard deleted the trallard/gitpod-patch branch May 27, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants