-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Gitpod to use the Docker image #5
Conversation
Ran the tests again and now it all works as expected 🎉 - @gabalafou or @tonyfast can you do a sanity check and merge? 🙏🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm still seeing an issue when I do the following:
- Open PR #5 in Gitpod
cd testing/jupyterlab
yarn test
The issue is that error message we saw before: that we need to run npx playwright install
.
Here's a screenshot:
Follow up. If I run |
Are you opening Gitpod from master or from this branch? @gabalafou Not sure if you will be able to access my logs https://gitpod.io/projects/accessibility/83f468d6-33ef-4dfc-9a5c-c092cfe67913 but you can see the pre-build is completing all these installs |
I was opening from this branch/PR by going to this URL: https://gitpod.io/#https://github.com/Quansight-Labs/accessibility/pull/5 |
When I go to the logs url you pasted, all I see is one line:
|
It makes no sense. All I can tell you is that when I was playing around with Gitpod, the only way I could get this to work is if I put |
Okay, here's a clue from my command log (pasted below). See how there's nothing in ~/.cache? But after I run
|
It should not matter unless you are jumping on an already made workspace anywho will merge for now and can improve later - esp if we are merging the other doit branch |
Last step following from #4 - this should make it so that we use the prebuilt image and enables pre-builds for Gitpod