move QuAlgorithmZoo to lib #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
license: ASL
authors: Roger-luo
years: 2018
user:
Julia Version 0.6.3 [d55cadc350]
* Create VQE_H2_4bit.ipynb add example for H2 under Jordan-Weigner transformation with OpenFermion * Update and rename VQE_H2_4bit.ipynb to H2_OpenFermion.jl change the notebook to Literate.jl format for better maintenance * Update README.md
correct reference to global variable h->hamiltonian
the SCSsolver is deprecated in new SCS, shoud be SCS.optimizer now
* switch to chainrules * switch to Zygote
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 77.63% 77.63%
=======================================
Files 22 22
Lines 1203 1203
=======================================
Hits 934 934
Misses 269 269 Continue to review full report at Codecov.
|
|
I'd prefer delay this decision. Why are the tests rely on QuAlgorithmZoo? |
|
not tests, documentation depends on this package |
|
close in favor of #315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tutorial depends on this QuAlgorithmZoo, currently dev this in CI slow down the build time. I think we can just move it into
libfirst, and improve them later