-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move some utilities in YaoExtensions to Yao.EasyBuild submodule. #315
Conversation
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 80.02% 80.02%
=======================================
Files 68 68
Lines 3524 3524
=======================================
Hits 2820 2820
Misses 704 704 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other parts LGTM
A general single qubits gate: ``e^(iϕ)R_z(θ_3)R_y(θ_2)R_z(θ_1)``. | ||
Leave `ϕ` as `nothing` to fix the global phase. | ||
""" | ||
function general_U2(θ1, θ2, θ3; ϕ=nothing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this just be a block? this is also needed to map to openQASM etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds good, but let us do it in another PR. Let us convert your comment to an issue?
Some blocks and circuit builders.
List of blocks
List of shortcuts
cphase
andCPhaseGate
List of circuits
List of hamiltonians
NOTE 1: they are not exported to the global scope, one has to type
to access these features in Yao's submodule.
NOTE 2: the reason why some blocks are not added
It does not mean other blocks are useful, will consider removing them in the future, they are in the deleting list. When a block can be replace by a combination of other blocks, I prefer not creating a new type except there is a practical using case.