Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: mutex: fix DEBUG pointer output #10354

Merged
merged 1 commit into from
Nov 9, 2018
Merged

core: mutex: fix DEBUG pointer output #10354

merged 1 commit into from
Nov 9, 2018

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 9, 2018 •
edited
Loading

Contribution description

Out of interest after some offline discussions regarding #10121 I tried to compile hello-world for native without the -m32 flag. Apart from obviously required adaptations in cpu/native (which needs some rework for 64-bit support), I only found some pointer conversion errors in the debug output of core/mutex. I don't know why the output originally was converted to an integer in 350c341, but maybe @kaspar030 can answer that?

Testing procedure

tests/mutex_order should still compile with ENABLE_DEBUG == 1 in core/mutex.c and provide sensible debug output.

Issues/PRs references

None, but out of curiosity if #10121 can be fixed by providing 64-bit support.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: core Area: RIOT kernel. Handle PRs marked with this with care! labels Nov 9, 2018
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 9, 2018
@kaspar030
Copy link
Contributor

I don't know why the output originally was converted to an integer in 350c341, but maybe @kaspar030 can answer that?

At some point I didn't know about "%p", so I used "0x%08x" everywhere. That needs (unsigned) casts if passed a pointer...

kaspar030
kaspar030 approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit 92a2c16 into RIOT-OS:master Nov 9, 2018
@miri64 miri64 deleted the core/enh/fix-debug-msg branch December 28, 2018 14:25
@aabadie aabadie added this to the Release 2019.01 milestone Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@jnohlgard jnohlgard Awaiting requested review from jnohlgard

@kYc0o kYc0o Awaiting requested review from kYc0o

Assignees
No one assigned
Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @kaspar030 @aabadie