Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_now: use NETDEV_TYPE_ESP_NOW as device type #10509

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 29, 2018

Contribution description

This device should get its own device type similar to the cc110x as it is its own protocol. Using NETDEV_TYPE_RAW might lead to problems in the long run if other devices use the same device type but have different addressing schemes.

Testing procedure

Applications using IPv6 ESP-Now should still work as before (can't test since I don't have access to these kind of devices).

Issues/PRs references

None so far, but goes towards an effort to improve device-type-based address handling for gnrc_netif.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 29, 2018
@miri64 miri64 requested a review from gschorcht November 29, 2018 12:39
@gschorcht
Copy link
Contributor

gschorcht commented Nov 29, 2018

Tested it with two different ESP32 boards

USEMODULE=esp_now make flash -C examples/gnrc_networking BOARD=esp32-wroom-32 port=/dev/ttyUSB0

and

USEMODULE=esp_now make flash -C examples/gnrc_networking BOARD=esp32-mh-et-live-minikit flash PORT=/dev/ttyUSB1

@miri64 miri64 merged commit f71af3b into RIOT-OS:master Nov 29, 2018
@miri64 miri64 deleted the esp_now/fix/devtype branch November 29, 2018 14:25
@gschorcht
Copy link
Contributor

Thanks, I have to this also for PR #9917

@miri64
Copy link
Member Author

miri64 commented Nov 29, 2018

Thanks you for the review :-)

@aabadie aabadie added this to the Release 2019.01 milestone Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants