gnrc: remove ESP-Now related code-duplication #10515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Area: network
gschorcht
approved these changes
Nov 29, 2018
|
I don't know why I did a copy instead of using the existing code. Maybe, I wanted to have it more clear or I thought that the NETDEV_TYPES* are only available when the according modules are enabled. |
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 29, 2018
…tif/enh/iid-conversion
6 tasks
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
ESP-Now addresses seem to be basically EUI-48s (at least in the way they are converted into an IPv6 IID). So there is no reason to create code duplication for it.
Testing procedure
IPv6 over ESP-Now should still work.
Issues/PRs references
Follow-up on #10509.