Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_netif_hdr: provide wrappers for gnrc_netif_ipv6_iid_from_addr() #10520

Merged
merged 1 commit into from
Dec 7, 2018
Merged

gnrc_netif_hdr: provide wrappers for gnrc_netif_ipv6_iid_from_addr() #10520

merged 1 commit into from
Dec 7, 2018

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 29, 2018 •
edited
Loading

Contribution description

These will provide some convenience when reworking gnrc_sixlowpan_iphc for non-IEEE802.15.4 address compression.

Testing procedure

If reviewer asks for it I will provide some unittests in tests/gnrc_netif but that it works when #10513 works should be clear from the code.

Issues/PRs references

Depends on #10513 (merged) and its dependencies.

gnrc_netif/gnrc_sixlowpan_iphc BLE capability

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking labels Nov 29, 2018
@miri64 miri64 requested a review from haukepetersen November 29, 2018 21:26
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 29, 2018
@miri64
Merge branch 'gnrc_netif_hdr/enh/conv-iid-getter' (RIOT-OS#10520) int…
20e4758 
…o HEAD
@miri64 miri64 mentioned this pull request Nov 29, 2018
Merged
@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 30, 2018
@miri64 miri64 force-pushed the gnrc_netif_hdr/enh/conv-iid-getter branch from b2c170a to 6bc5d0e Compare November 30, 2018 08:47
@miri64
Copy link
Member Author

miri64 commented Nov 30, 2018

Rebased to current master and #10513.

@miri64 miri64 changed the title gnrc_netif_hdr: provide wrappers for gnrc_netif_iid_from_addr() gnrc_netif_hdr: provide wrappers for gnrc_netif_ipv6_iid_from_addr() Nov 30, 2018
@miri64 miri64 force-pushed the gnrc_netif_hdr/enh/conv-iid-getter branch from 6bc5d0e to aafb936 Compare November 30, 2018 08:48
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 30, 2018
@miri64
Merge branch 'gnrc_netif_hdr/enh/conv-iid-getter' (RIOT-OS#10520) in…
bf21d93 
…to HEAD
@miri64 miri64 force-pushed the gnrc_netif_hdr/enh/conv-iid-getter branch from aafb936 to f86ad9d Compare December 5, 2018 14:49
@miri64
Copy link
Member Author

miri64 commented Dec 5, 2018

Rebased to current master and #10513.

@miri64 miri64 force-pushed the gnrc_netif_hdr/enh/conv-iid-getter branch from c9c951f to b2017f5 Compare December 5, 2018 14:55
@miri64
Copy link
Member Author

miri64 commented Dec 5, 2018

And again :-D

miri64 added a commit to miri64/RIOT that referenced this pull request Dec 5, 2018
@miri64
Merge branch 'gnrc_netif_hdr/enh/conv-iid-getter' (RIOT-OS#10520) in…
8f8a3ad 
…to HEAD
haukepetersen
haukepetersen requested changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor style issue, else the changes look valid to me. Will test once its rebased.

sys/include/net/gnrc/netif/hdr.h Outdated Show resolved Hide resolved
@miri64 miri64 force-pushed the gnrc_netif_hdr/enh/conv-iid-getter branch from 2872116 to 1a6d4fd Compare December 6, 2018 14:58
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Dec 6, 2018
@miri64
Copy link
Member Author

miri64 commented Dec 6, 2018

Rebased and squashed to current master. This PR no longer has any dependencies.

haukepetersen
haukepetersen previously approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 force-pushed the gnrc_netif_hdr/enh/conv-iid-getter branch from 1a6d4fd to d1e8f93 Compare December 6, 2018 15:02
@miri64
Copy link
Member Author

miri64 commented Dec 6, 2018

Somehow the #include "net/gnrc/netif/internal.h" change got lost here. I amended it

@miri64 miri64 force-pushed the gnrc_netif_hdr/enh/conv-iid-getter branch from d1e8f93 to 77dd725 Compare December 6, 2018 15:17
@miri64
Copy link
Member Author

miri64 commented Dec 6, 2018

Amended doxygen error fix pointed out by Travis.

@miri64 miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 6, 2018
@miri64
Copy link
Member Author

miri64 commented Dec 6, 2018

Needs #10565 to be buildable by Murdock :-/

@miri64
Copy link
Member Author

miri64 commented Dec 6, 2018

Also provided the proposed change from #10565 (comment) as a fixup commit.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 6, 2018
haukepetersen
haukepetersen approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK, no unsused param warnings for my NimBLE-CCN-lite build anymore.

@haukepetersen
Copy link
Contributor

please squash

@miri64 miri64 force-pushed the gnrc_netif_hdr/enh/conv-iid-getter branch from c5d7941 to 4d4e96f Compare December 7, 2018 12:00
@miri64
Copy link
Member Author

miri64 commented Dec 7, 2018

Squashed

@haukepetersen
Copy link
Contributor

nice. Go Murdock!

@haukepetersen
Copy link
Contributor

all green -> go

@haukepetersen haukepetersen merged commit bdc1b89 into RIOT-OS:master Dec 7, 2018
@miri64 miri64 deleted the gnrc_netif_hdr/enh/conv-iid-getter branch December 7, 2018 15:00
@aabadie aabadie added this to the Release 2019.01 milestone Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoRoth TimoRoth TimoRoth left review comments

@haukepetersen haukepetersen haukepetersen approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @haukepetersen @TimoRoth @aabadie