-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc/netif/internal: fix copy-paste error #10565
gnrc/netif/internal: fix copy-paste error #10565
Conversation
the names for iid_from_addr and iid_to_addr functions in the else-block were switched around, so this fixes that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, obvious ACK.
Hm, there is unfortunately more to this: when compiling the non-ipv6 case, |
Don't see any other way around it. Or just |
Where are those functions compiled without IPv6 btw? |
(because IPHC should be excluded without IPv6) |
Maybe (if you are trying to run NDN over BLE at the moment) you need #10379? |
In anyway, that seems to be more of a usage problem of those functions (or this one) so I'll go ahead and merge it, as soon as Murdock agrees. |
Ah ... I see... tests ^^" |
Contribution description
#10513 introduced a small error for the case that no IPv6 is compiled in:
gnrc_netif_ipv6_iid_from_addr()
andgnrc_netif_ipv6_iid_to_addr()
are supposed to be defined to a static-ENOTSUP
in that case - but there names where switched around, so that we get compile errors complaining about the wrong number of parameters...Testing procedure
At least on my local machine, building
ccn-lite-relay
failed for native. With this PR it does not fail anymore... But I wonder how Murdock was able to build that example when doing the build-test for #10513...Issues/PRs references
#10513