boards/frdm-k64f: hack disable periph_hwrng as it crashes #11454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same disable as in `frdm-kw41z`.
cladmi
added
Type: bug
|
This is fixing all the following tests: --- 2019.04-RC1/frdm-k64f/failuresummary.md 2019-04-24 19:17:40.000000000 +0200
+++ 2019.04-RC1_periph_hwrng_fix/frdm-k64f/failuresummary.md 2019-04-26 16:50:14.000000000 +0200
@@ -1,29 +1,8 @@
Failures during test:
- [tests/gnrc_ipv6_ext](tests/gnrc_ipv6_ext/test.failed)
-- [tests/gnrc_ipv6_nib](tests/gnrc_ipv6_nib/test.failed)
-- [tests/gnrc_ipv6_nib_6ln](tests/gnrc_ipv6_nib_6ln/test.failed)
-- [tests/gnrc_ndp](tests/gnrc_ndp/test.failed)
-- [tests/gnrc_netif](tests/gnrc_netif/test.failed)
- [tests/gnrc_rpl_srh](tests/gnrc_rpl_srh/test.failed)
-- [tests/gnrc_sixlowpan](tests/gnrc_sixlowpan/test.failed)
- [tests/gnrc_sock_dns](tests/gnrc_sock_dns/test.failed)
-- [tests/gnrc_sock_ip](tests/gnrc_sock_ip/test.failed)
-- [tests/gnrc_sock_udp](tests/gnrc_sock_udp/test.failed)
-- [tests/nhdp](tests/nhdp/test.failed)
- [tests/periph_rtt](tests/periph_rtt/test.failed)
- [tests/periph_timer](tests/periph_timer/test.failed)
-- [tests/pkg_c25519](tests/pkg_c25519/test.failed)
- [tests/pkg_fatfs_vfs](tests/pkg_fatfs_vfs/test.failed)
-- [tests/pkg_hacl](tests/pkg_hacl/test.failed)
-- [tests/pkg_libcoap](tests/pkg_libcoap/test.failed)
-- [tests/pkg_libcose](tests/pkg_libcose/test.failed)
-- [tests/pkg_libhydrogen](tests/pkg_libhydrogen/test.failed)
-- [tests/pkg_micro-ecc-with-hwrng](tests/pkg_micro-ecc-with-hwrng/test.failed)
-- [tests/pkg_monocypher](tests/pkg_monocypher/test.failed)
-- [tests/pkg_qdsa](tests/pkg_qdsa/test.failed)
-- [tests/pkg_tweetnacl](tests/pkg_tweetnacl/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
-- [tests/pthread_barrier](tests/pthread_barrier/test.failed)
-- [tests/pthread_rwlock](tests/pthread_rwlock/test.failed)
-- [tests/rng](tests/rng/test.failed)
-- [tests/trickle](tests/trickle/test.failed) |
|
@cladmi looks good but I don't have kw64f, only kw41z so I can't really test. |
jcarrano
approved these changes
Apr 29, 2019
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Disable the
frdm-k64fas is it misconfigured since 925a908Use the same disable as in
frdm-kw41z.It fixes breakage with all firmwares using
rng.This is not the fix to make
hwrngwork but only disable it until fixed.Testing procedure
tests/periph_hwrngRun
tests/periph_hwrngcrashes with thefrdm-k64fnow it is said to be unsupported (still crashes).Firmwares using
rng:examples/gnrc_networkingfor example, does not crash anymore as it does not usehwrnganymore.examples/gnrc_networkingforfrdm-k64fwithmaster:Issues/PRs references
Issue: #11447
It does not closes the issue as it is not a fix to make the 'hwrng' but disable it until fixed.
The test automation for testing
tests/periph_hwrng#11448