cpu/kinetis: enable HWRNG for k64f #11985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjmolinas
added
Platform: ARM
|
@cladmi might want to take a look at this. |
jcarrano
suggested changes
Aug 9, 2019
| * @name Hardware random number generator module configuration | ||
| * | ||
| * For K64F SCG3 or SCG6 can be used depending on if the the | ||
| * peripheral is accessed threw AIPS-lite0 or AIPS-lite1. |
There was a problem hiding this comment.
Suggested change
| * peripheral is accessed threw AIPS-lite0 or AIPS-lite1. | |
| * peripheral is accessed through AIPS-lite0 or AIPS-lite1. |
- Fix SCGx used for RNGA since RNGA is not mapped to SCG3 for K64F.
fjmolinas
force-pushed
the
pr_k64f_hwrng
branch
from
b9f5f6b to
0ce2081
Compare
fjmolinas
added
the
CI: ready for build
|
I did not know about https://github.com/fjmolinas/RIOT/blob/0ce2081817af689905843885c9a32f4ec50fbd23/cpu/kinetis/include/cpu_conf_kinetis_k.h Thanks for addressing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
HWRNG was disabled for
frdm-k64fin #11454 because 925a908 broke the support.When looking at
kinetis k64reference manual under (AIPS-Lite0andAIPS-Lite1):If the peripheral Bridge for
AIPS-Lite-0andAIPS-Lite-1,RNGAis only mapped inSCGC6, so it shouldn't useSCGC3fork64.See 4.5 and 4.5.2 in RM.
This PR changes the SCGx register used for RNGA to SCG3.
note: this PR doesn't address the fact that the hwrng implementation for kinetis is flawed since it returns 32 bits of a register with 1 bit of entropy
Testing procedure
make -C tests/periph_hwrng/ BOARD=frdm-k64f clean flash -j term
python dist/tools/compile_and_test_for_board/compile_and_test_for_board.py --jobs 2 . frdm-k64f --applications="tests/gnrc_ipv6_nib tests/gnrc_ipv6_nib_6ln tests/gnrc_ndp tests/gnrc_netif tests/gnrc_sixlowpan tests/gnrc_sock_ip tests/gnrc_sock_udp tests/nhdp tests/pkg_c25519 tests/pkg_hacl tests/pkg_libcoap tests/pkg_libcose tests/pkg_libhydrogen tests/pkg_micro-ecc-with-hwrng tests/pkg_monocypher tests/pkg_qdsa tests/pkg_tweetnacl tests/pthread_barrier tests/pthread_rwlock tests/rng tests/trickle"
Issues/PRs references
Related to #11454
Fixes #11447