-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/esp32: use esptool.py from PATH #12028
Conversation
For me the updated documentation makes sense and looks good. (I looked at the html). It may be better to change already to diff --git a/cpu/esp32/Makefile.include b/cpu/esp32/Makefile.include
index 850a72402..d011791fc 100644
--- a/cpu/esp32/Makefile.include
+++ b/cpu/esp32/Makefile.include
@@ -61,7 +61,7 @@ PSEUDOMODULES += esp_wifi_any
export CPU ?= esp32
export TARGET_ARCH ?= xtensa-esp32-elf
-export ESPTOOL ?= $(ESP32_SDK_DIR)/components/esptool_py/esptool/esptool.py
+export ESPTOOL ?= esptool.py
USEMODULE += esp_idf
USEMODULE += esp_idf_driver |
@MrKevinWeiss you were testing the last esp PRs so may be interested |
I can go through the procedure after the summit! Ping again if I forget. |
114fdf7
to
2fc7c9c
Compare
This allows flashing using `esptool.py` install from pip. The documentation already state that `esptool.py` must be put available in the path and that it is possible to use the `pip` version.
2fc7c9c
to
af95273
Compare
@MrKevinWeiss ping summit is over :) |
Many thanks, I am on it! |
I was trying to go through the The pip install stuff works great though. |
Indeed, ubuntu seems to ship it named as https://packages.ubuntu.com/xenial/amd64/esptool/filelist I think because the first versions were binary versions not implemented in python and they kept the name compatibility. Also only https://packages.ubuntu.com/disco/esptool I do not expect any packages from 'xenial' (16.04) to be supported though. |
The |
Sorry, I'm on vacation and can't do much from here. The |
Does this become obsolete with #11108? |
Hm, if |
Closed in favor of PR #12750 |
Contribution description
This PR removes the use of
esptool.py
from ESP32 SDK. Instead,esptool.py
installed from pip is used. This makes it possible to flash and reset ESP32 without the SDK installed using PORT.The documentation is updated to clarify esptool.py installation.
Testing procedure
Generate the documentation with
and install
esptool.py
according to the documentation.Compile and flash any application for an ESP32 board using docker:
If the default port doesn't work, use the PORT variable to define the port, for example:
Issues/PRs references
Related to PR #11646.