Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/esp32: use esptool.py from riot tools #12750

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Nov 20, 2019

Contribution description

The ESP8266 port requires a modified esptool.py version, which is shipped with the ESP8266 RTOS SDK and not available as git repository or distribution package. To be able to flash an image without the RTOS SDK installed, this modified esptool.py version was extracted from the RTOS SDK and added to dist/tools.

This modified esptool.py version can also be used for the ESP32 port. Thus, it becomes possible to flash an image without the installation of the ESP-IDF SDK or a separate installation of the esptool.py.

Testing procedure

Flash any application, for example

make BOARD=esp32-wroom-32 -C tests/shell flash

Issues/PRs references

Replaces PR #12028
Prerequisite for PR #12752

cpu/esp32/doc.txt Outdated Show resolved Hide resolved
cpu/esp32/doc.txt Outdated Show resolved Hide resolved
cpu/esp32/doc.txt Outdated Show resolved Hide resolved
@yegorich
Copy link
Contributor

Successfully tested against TTGO T-Beam.

@gschorcht
Copy link
Contributor Author

gschorcht commented Nov 20, 2019

@yegorich Thanks for reviewing and testing.

@MrKevinWeiss This is the answer to your question, whether the modified version of the esptool.py for the ESP8266 port can also be used for ESP32.

@gschorcht gschorcht added Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Nov 20, 2019
cpu/esp32/Makefile.include Outdated Show resolved Hide resolved
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, please squash!

Flashing on ESP32 works with the esptool.py provided in dist/tools (the default) and overriding ESPTOOL from the command line is also usable.

Use esptool.py from riot tools instead from ESP-IDF SDK to avoid that the SDK has to be installed to flash an image.
@gschorcht
Copy link
Contributor Author

Squashed.

@aabadie aabadie merged commit fe255a2 into RIOT-OS:master Nov 21, 2019
@gschorcht
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants