-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/tensorflow-lite: blacklist esp32 architecture [backport 2020.01] #13150
pkg/tensorflow-lite: blacklist esp32 architecture [backport 2020.01] #13150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A straightforward solution as tested in the master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
(cherry picked from commit 556914f)
9b65a64
to
bdfb39f
Compare
@fjmolinas, it seems that your ACK was dismissed when I force pushed the updated branch (the branch must be up to date with the release branch..., btw why this? ) |
Rebased on the release branch? No idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-ACK
In fact, each backport PR in the queue must be rebased when another one is merged in the meantime. This is quite annoying. |
It is, but it ensures that CI tested the actual result of a merge to the current release branch HEAD. Without this, there are merge interaction race conditions. |
Agreed, and I'm not against this. It is annoying because there are 3 backport PRs in the queue and Murdock takes 30m to build each PRs including random PRs that target master. Would it be possible to reorder the priority of backport PRs in the Murdock queue ? |
Not at the moment. |
No problem, but would be a great feature to add to Murdock ;) |
Backport of #13140
Contribution description
As proposed in #13133 (comment), this PR blacklists the ESP32 architecture in the tensorflow-lite package.
Testing procedure
Issues/PRs references
This is a workaround for the problem reported in #13133 on ESP32 (details in #13133 (comment))