Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/tensorflow-lite: blacklist esp32 architecture #13140

Merged

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jan 16, 2020

Contribution description

As proposed in #13133 (comment), this PR blacklists the ESP32 architecture in the tensorflow-lite package.

Testing procedure

  • Check that pkg/tensorflow-lite build is forbidden by the build system on esp32 architecture:
BUILD_IN_DOCKER=1 make BOARD=esp32-wroom-32 -C tests/pkg_tensorflow-lite
make: Entering directory '/work/riot/RIOT/tests/pkg_tensorflow-lite'
ESP32_SDK_DIR should be defined as /path/to/esp-idf directory
ESP32_SDK_DIR is set by default to /opt/esp/esp-idf
Some feature requirements are blacklisted: arch_esp32
/work/riot/RIOT/tests/pkg_tensorflow-lite/../../Makefile.include:843: *** You can let the build continue on expected errors by setting CONTINUE_ON_EXPECTED_ERRORS=1 to the command line.  Stop.

Issues/PRs references

This is a workaround for the problem reported in #13133 on ESP32 (details in #13133 (comment))

@aabadie aabadie added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before labels Jan 16, 2020
@aabadie aabadie requested a review from gschorcht January 16, 2020 07:03
@aabadie aabadie requested a review from fjmolinas January 16, 2020 07:07
@aabadie aabadie added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jan 16, 2020
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A straightforward change.

@gschorcht
Copy link
Contributor

@aabadie Thanks for providing the change so fast. I had it on my plan for today 😉

@gschorcht gschorcht removed the CI: run tests If set, CI server will run tests on hardware for the labeled PR label Jan 16, 2020
@gschorcht
Copy link
Contributor

I removed the CI run test label to make Murdock happy. Running the tests fails for nrf52dk which is not related to this PR. I have checked the Murdock build. tests/pkg_tensorflow-lite isn't compiled for ESP32 boards.

@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 16, 2020
@gschorcht gschorcht merged commit 27764fe into RIOT-OS:master Jan 16, 2020
@aabadie aabadie deleted the pr/pkg/tensorflow-lite-blacklist-esp32 branch January 16, 2020 09:25
@aabadie
Copy link
Contributor Author

aabadie commented Jan 16, 2020

@fjmolinas, is it ok if I provide a backport ? It seems that the new esp32 toolchain won't be deployed for this release (see RIOT-OS/riotdocker#97 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants