Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: Initial support for Ellduino #1740

Closed
wants to merge 7 commits into from
Closed

boards: Initial support for Ellduino #1740

wants to merge 7 commits into from

Conversation

latsku
Copy link
Contributor

@latsku latsku commented Sep 30, 2014

Hello

This is a first version of support for ELL-i's Ellduino development board.

Short description of the board can be found here:
https://github.com/Ell-i/Hackathon/wiki/Ellduino-development-board

The board does not have an external oscillator and therefore had to move stm32f0 HSE clock initialization to f0 discovery board initialization.

mehlis
mehlis reviewed Sep 30, 2014
View reviewed changes
boards/stm32f0discovery/board.c
/* wait for sysclock to be stable */
while (!(RCC->CFGR & RCC_CFGR_SWS_PLL));

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@mehlis
Copy link
Contributor

mehlis commented Sep 30, 2014

@latsku side question: do you have some hardware to purchase with you tomorrow at hack'n'ACK?

@latsku
Copy link
Contributor Author

latsku commented Sep 30, 2014

@mehlis I'm not attending tomorrow and don't know if Teemu and Pekka has extra boards with them.

@OlegHahm OlegHahm added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Sep 30, 2014
thomaseichinger
thomaseichinger reviewed Oct 1, 2014
View reviewed changes
boards/ellduino/board.c
* @file
* @brief Board specific implementations for the ELL-i ellduino board
*
* @author Lari Lehtomäki <lari@lehtomaki.fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing >

@thomaseichinger
Copy link
Member

There was a bug in Travis configuration which was fixed last night. So please rebase on current master branch. Also, you'll need to add Ellduino to BOARD_BLACKLIST variable in examples and tests Makefiles where applicable.

@haukepetersen
Copy link
Contributor

@latsku I just got my hands on one of your boards, but unfortunately you code does not work (building the hello-world application). I just don't get an answer from the board on the uart after flashing... Any idea?

@haukepetersen haukepetersen added this to the Release NEXT MAJOR milestone Oct 2, 2014
@haukepetersen haukepetersen added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Oct 2, 2014
@temmihoo
Copy link

temmihoo commented Oct 2, 2014

Hauke, I found out why the shell didn't work. As you guessed just before leaving the FU, the problem was trying to use wrong USART. The programming plug is connected to PA14/PA15 ie. USART2. In Riot-OS parlance that might be UART_1. I'm using the names from chip datasheet.

From my very brief look at things, it seems that just changing STDIO in boards.h could do the trick as UART*EN in periph_conf.h are already enabled.

No, I didn't test it, just commenting.

@haukepetersen
Copy link
Contributor

@temmihoo Hm, I did try out some combinations of UART1/UART2 and the pins you named, I still don't get any output on the programming adapter after flashing... Something in the pin-config seems still to do something unexpected...

And while we are at it, could you maybe create a short page in the RIOT wiki (just look at other board pages), that describes how you flash the device? I had again to take some time to figure out that I needed the patched stm32flash tool version from the ELL-I wiki to get it working... Thx!

@thomaseichinger
Copy link
Member

@latsku please rebase.

@OlegHahm
Copy link
Member

Rebase is required again, also some blacklisting and extern C in two headers is missing.

@haukepetersen
Copy link
Contributor

@latsku could you rebase?

@OlegHahm
Copy link
Member

I guess we have to postpone this for the next release.

@latsku
Copy link
Contributor Author

latsku commented Dec 16, 2014

Hi,

I have been unavailable to update the pull request as I have been in a hurry with my studies.

After the rebase issues are fixed, there is still some issue with the serial communication and atleast personally I would like have working serial before this is included in master. Ellduino board has some hardware flaw, which causes signals from FTDI chip to hold cpu on reset. This is used to reset the chip after programming, but it also interferes with plain serial communication.
If I remember correctly programming the chip with full FTDI header connected and afterward running serial line only using rx, tx, and ground with jumper wires should work, but might as well remember wrongly.

I talked with Teemu about this but forgot to update the situation as we met yesterday. I hoped someone else from ELL-i could maybe help with debugging the serial issue.

If you are releasing new milestone before Christmas, then I vote also for postponing this.
We could also close this PR at the moment and continue when the serial issue is fixed.

@haukepetersen
Copy link
Contributor

@latsku I agree with you that the serial should be working before we merge this, so postponing this PR for after the release seems to be the right choice. I would however not close this PR, as it might be useful for others and it serves us as remainder. Let us know when you found your bugs and how we can assist!

@OlegHahm OlegHahm modified the milestones: Release NEXT MAJOR, Release 2014.12 Dec 16, 2014
@thomaseichinger
Copy link
Member

@latsku Do you plan to put any work into this?

@OlegHahm OlegHahm force-pushed the master branch 2 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01
@OlegHahm
Copy link
Member

@latsku, ping!

@latsku
Copy link
Contributor Author

latsku commented Aug 18, 2015

@OlegHahm Pong

I rebased this on top of master and fixed emerging issues. Also found couple mistakes on serial configuration, but couldn't get the serial working.

  • The board has a known hardware bug on serial lines, which requires some black magic with DTR/CTS to boot properly. (DTR or CTS should be inverted, can't remember which one.)
  • Flashing the board requires custom stm32flash.
  • This is one time prototype board from ELL-i, which isn't going to get re-run in my best knowledge.

With these in mind, it doesn't really make sense to push further with this pull request.

@latsku latsku closed this Aug 18, 2015
@OlegHahm
Copy link
Member

Ok, thanks for the response!

@OlegHahm OlegHahm modified the milestone: Release 2015.12 Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@latsku @mehlis @thomaseichinger @haukepetersen @temmihoo @OlegHahm