Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental] rust: Update versions #17491

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Jan 8, 2022

[updated description; see below the line for the original version]

This PR is a template for what needs to be done when updating the riot-sys and riot-wrappers Rust crates used in the examples. Usual steps are:

for x in examples/rust* tests/rust*; do cd $x; cargo update || break; make BOARD=samd21-xpro CARGO_CHANNEL=nightly || break; cd -; done
git commit */*/Cargo.lock -m "rust: Update versions"
  • Push that into a new PR, briefly summarizing why an update is necessary.
  • Let Murdock, ACKs and merging take their course.

Apart from being useful as a template for other PRs, this PR is also occasionally used to just run these steps (force pushing, without an intention to merge) to get the latest -sys and -wrappers tested by Murdock.


This is a test balloon for how #17488 could turn out.

This is a draft commit because the git repo is not yet one RIOT controls, and anyhow there's no good reason to switch to an unreleased version right now.

@github-actions github-actions bot added Area: examples Area: Example Applications Area: tests Area: tests and testing framework labels Jan 8, 2022
@chrysn chrysn added Area: Rust Area: Rust wrapper CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR and removed Area: tests Area: tests and testing framework Area: examples Area: Example Applications labels Jan 8, 2022
@github-actions github-actions bot added Area: examples Area: Example Applications Area: tests Area: tests and testing framework labels Jan 10, 2022
@chrysn chrysn removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 17, 2022
@chrysn chrysn added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 17, 2022
@chrysn
Copy link
Member Author

chrysn commented Jan 17, 2022

There are now clones of the relevant crates in https://github.com/RIOT-OS-pkgmirror.

By now, this always-experimental PR is not showing how they'd be used (which should be straightforward from swapping around the upstreams), but also to give branches of riot-sys and -wrappers a trial run on the full set of boards rather than the limited set their own CI can do.

@chrysn chrysn force-pushed the rust-updates branch 5 times, most recently from b740d99 to 2d582c5 Compare January 27, 2022 07:58
@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Jan 27, 2022
@github-actions github-actions bot removed the Area: tools Area: Supplementary tools label Mar 4, 2022
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022
@chrysn chrysn force-pushed the rust-updates branch 3 times, most recently from e968cf3 to e079086 Compare May 3, 2022 06:54
@chrysn
Copy link
Member Author

chrysn commented Jun 1, 2022

With #18151 merged, this branch can now be generated more easily: Just run

for x in examples/rust* tests/rust*; do cd $x; cargo update || break; make BOARD=samd21-xpro CARGO_CHANNEL=nightly || break; cd -; done
git commit */*/Cargo.lock -m "rust: Update versions"

(which includes a simple local build check just see issues early).

The top description is being updated to reflect how this PR works now.

@chrysn chrysn removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 8, 2022
@chrysn chrysn merged commit f4691db into RIOT-OS:master Jun 9, 2022
@chrysn
Copy link
Member Author

chrysn commented Jun 9, 2022

This was accidentally marked as merged when the branch happened to be on the same commit as a different PR (that was not experimental/always-open) and the latter was merged. Trying to re-open it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: examples Area: Example Applications Area: Rust Area: Rust wrapper Area: tests Area: tests and testing framework CI: run tests If set, CI server will run tests on hardware for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants