Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: Build from git branches #18151

Merged
merged 2 commits into from
May 31, 2022
Merged

Rust: Build from git branches #18151

merged 2 commits into from
May 31, 2022

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented May 31, 2022

Contribution description

With Rust crate repositories currently being created in the RIOT group, this uses the repositories, allowing maintainers (with the usual ACKs) to fix breakage without the need to go through a crates.io release.

This enacts a switch discussed in a recent maintainers meeting.

Testing procedure

  • Green CI
  • Check whether the referenced repositories have something CI-like set up.

chrysn added 2 commits May 31, 2022 17:42
@chrysn
Rust: Use git versions of riot-{sys,wrappers} by default
fdc4e11 
This makes it easier for all maintainers to adjust to C-nonbreaking but
Rust-breaking API changes, as regular `cargo update` steps don't require
a crates.io release any more.
@chrysn
{examples,tests}/rust: Rust updates
f89324a 
This is not so much an update (riot-wrappers stays at the same commit,
riot-sys just advances by one that re-enables an optional dependency,
but of course third party crates are updated) but more reflects the
switch from using released crates to git versions.
@chrysn chrysn added Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: Rust Area: Rust wrapper labels May 31, 2022
@github-actions github-actions bot added Area: examples Area: Example Applications Area: tests Area: tests and testing framework labels May 31, 2022
@chrysn chrysn removed Area: tests Area: tests and testing framework Area: examples Area: Example Applications labels May 31, 2022
@chrysn
Copy link
Member Author

chrysn commented May 31, 2022

The referenced branches now have CI set up.

I'll have to do a round of checks as to whether developer documentation needs updating (there's some in tests/rust_minimal/README.md), but from the technical aspects I think this is ready for review.

@chrysn chrysn marked this pull request as ready for review May 31, 2022 18:40
@kaspar030
Copy link
Contributor

kaspar030 commented May 31, 2022 •
edited
Loading

So, these are not pinned? That means one RIOT CI commit build does not consistently point to the same code?
The referenced repos might change during a bisect?
Not possible anymore to check out a riot commit and reproduce, without tracking the exact commits cargo patched in for the original reporter of an issue?

I think I'd prefer pinning to specific commits.

edit or are the exact versions pinned through Cargo.lock?

@chrysn
Copy link
Member Author

chrysn commented May 31, 2022 •
edited
Loading

They're pinned through the Cargo.lock files, as they were before.

[edit: read post on mail, missed your edit ;-) ]

kaspar030
kaspar030 approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 enabled auto-merge May 31, 2022 20:37
@kaspar030 kaspar030 merged commit 12b1b27 into RIOT-OS:master May 31, 2022
@chrysn chrysn deleted the riot-from-branches branch June 1, 2022 07:16
@chrysn chrysn mentioned this pull request Jun 1, 2022
Merged
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: Rust Area: Rust wrapper CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
2 participants
@chrysn @kaspar030