Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/slipdev: implement sleep states #17810

Merged
merged 1 commit into from
Jan 10, 2023
Merged

drivers/slipdev: implement sleep states #17810

merged 1 commit into from
Jan 10, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Mar 15, 2022 •
edited
Loading

Contribution description

This implements the SLEEP and STANDBY state analogous to DOSE. (In Standby, send will wake the device from sleep).
If slipdev_stdio is used this functionality is not available as we can not put the UART to sleep if it's used for stdio.

Testing procedure

ifconfig <id> set state sleep and ifconfig <id> set state idle should work.

Issues/PRs references

@benpicco benpicco requested a review from miri64 as a code owner March 15, 2022 20:46
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Mar 15, 2022
miri64
miri64 reviewed Mar 15, 2022
View reviewed changes
drivers/slipdev/slipdev.c Outdated Show resolved Hide resolved
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 20, 2022
@benpicco benpicco requested review from kaspar030 and jia200x March 25, 2022 16:51
@benpicco benpicco force-pushed the drivers/slipdev-standby branch from f68f8f3 to 2d4e382 Compare March 28, 2022 17:08
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 28, 2022
@miri64
Copy link
Member

miri64 commented May 24, 2022

Code looks good. How do I test?

@benpicco benpicco removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 25, 2022
miri64
miri64 reviewed May 25, 2022
View reviewed changes
drivers/slipdev/slipdev.c Outdated Show resolved Hide resolved
@benpicco benpicco added the State: waiting for maintainer State: Action by a maintainer is required label Oct 6, 2022
maribu
maribu approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@benpicco benpicco force-pushed the drivers/slipdev-standby branch from f087314 to bb08461 Compare January 10, 2023 11:24
@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Canceled.

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for maintainer State: Action by a maintainer is required labels Jan 10, 2023
@benpicco
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Jan 10, 2023
@bors @benpicco @kaspar030
Merge #17810 #19120
5630c90 
17810: drivers/slipdev: implement sleep states r=benpicco a=benpicco



19120: CI: seperate check-labels and check-commits workflows r=miri64 a=kaspar030



Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
Co-authored-by: Kaspar Schleiser <kaspar@schleiser.de>
@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Build succeeded:

@bors bors bot merged commit 385569c into RIOT-OS:master Jan 10, 2023
@benpicco benpicco deleted the drivers/slipdev-standby branch January 10, 2023 19:33
@jia200x jia200x added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 left review comments

@maribu maribu maribu approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@jia200x jia200x Awaiting requested review from jia200x

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @miri64 @maribu @jia200x