Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: seperate check-labels and check-commits workflows #19120

Merged
merged 1 commit into from
Jan 10, 2023
Merged

CI: seperate check-labels and check-commits workflows #19120

merged 1 commit into from
Jan 10, 2023

Conversation

kaspar030
Copy link
Contributor

Contribution description

They were doing completely seperate things.
Also, check-commits was unnecessarily re-run for every label change due to shared on:.

This'll make it easier to get #19101 in.

Testing procedure

Issues/PRs references

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jan 10, 2023
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Jan 10, 2023
@kaspar030 kaspar030 requested a review from miri64 January 10, 2023 11:45
@kaspar030 kaspar030 force-pushed the split_check-pr_workflow branch from f12b636 to 1e29dd3 Compare January 10, 2023 11:48
@miri64
Copy link
Member

miri64 commented Jan 10, 2023

Does bors still need an update?

@miri64
Copy link
Member

miri64 commented Jan 10, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@kaspar030
Copy link
Contributor Author

Does bors still need an update?

I don't think so, IIUC "check-commits (pr_check)" should still be reported as before.

@riot-ci
Copy link

riot-ci commented Jan 10, 2023

Murdock results

✔️ PASSED

1e29dd3 CI: seperate check-labels and check-commits workflows

Success Failures Total Runtime
1 0 1 59s

Artifacts

@miri64
Copy link
Member

miri64 commented Jan 10, 2023

bors merge

bors bot added a commit that referenced this pull request Jan 10, 2023
@bors @benpicco @kaspar030
Merge #17810 #19120
5630c90 
17810: drivers/slipdev: implement sleep states r=benpicco a=benpicco



19120: CI: seperate check-labels and check-commits workflows r=miri64 a=kaspar030



Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
Co-authored-by: Kaspar Schleiser <kaspar@schleiser.de>
@maribu
Copy link
Member

maribu commented Jan 10, 2023

bors cancel

@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Canceled.

@maribu
Copy link
Member

maribu commented Jan 10, 2023

bors merge

@miri64
Copy link
Member

miri64 commented Jan 10, 2023

bors cancel

Why?

@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Build succeeded:

@bors bors bot merged commit 385569c into RIOT-OS:master Jan 10, 2023
@kaspar030 kaspar030 deleted the split_check-pr_workflow branch January 10, 2023 20:20
@maribu
Copy link
Member

maribu commented Jan 10, 2023

bors cancel

Why?

Optimizing CI queues by letting another ACK'ed PR jump onto the merge train. See Matrix room for the discussion. (Also: The cancel and merge cmd can be in the same message, this makes it more reliable that the canceled PR also is added again before the next merge train is started.)

@miri64
Copy link
Member

miri64 commented Jan 11, 2023

See Matrix room for the discussion. (Also: The cancel and merge cmd can be in the same message, this makes it more reliable that the canceled PR also is added again before the next merge train is started.)

And the reasoning as well, simalar to issue/PR closure. I did not see the Matrix message and chat messages get lost easily in the chatter as well.

@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Jan 11, 2023
@kaspar030 kaspar030 mentioned this pull request Jan 13, 2023
Merged
@jia200x jia200x added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
5 participants
@kaspar030 @miri64 @riot-ci @maribu @jia200x