Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32: use ESP-IDF gpio HAL for periph/gpio #18270

Merged
merged 3 commits into from
Jul 15, 2022
Merged

cpu/esp32: use ESP-IDF gpio HAL for periph/gpio #18270

merged 3 commits into from
Jul 15, 2022

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jun 28, 2022 •
edited
Loading

Contribution description

This PR is a split-off from PR #17841 and provides:

  • the ESP-IDF gpio interface API for RIOT
  • the changes to use the ESP-IDF gpio HAL

Please note: The ESP-IDF gpio HAL is used in any case for the gpio_init* functions. For the GPIO access, however, the ESP-IDF gpio HAL is only used if the esp_idf_gpio_hal module is enabled. Otherwise, the peripheral GPIO driver still uses direct access to the GPIO input/output registers for better performance and for future implementation of the gpio_ll API.

This PR depends on PR #18261

Testing procedure

Compile and test basic GPIO functionality with

BOARD=esp32-wroom-32 make -j8 -C tests/periph_gpio flash term

Issues/PRs references

Split-off from PR #17841
Depends on PR #18261
Prerequisite for PR #18271
Prerequisite for PR #18279

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 28, 2022
@gschorcht gschorcht requested a review from benpicco June 28, 2022 11:28
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first labels Jun 28, 2022
@gschorcht gschorcht mentioned this pull request Jun 28, 2022
Merged
@benpicco benpicco requested a review from maribu June 28, 2022 14:35
@gschorcht gschorcht force-pushed the cpu/esp32/periph_hal_esp32_gpio branch from 2a64946 to 77f8748 Compare June 28, 2022 14:43
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Jun 28, 2022
@gschorcht gschorcht changed the title cpu/esp32: use ESP-IDF gpio HAL cpu/esp32: use ESP-IDF gpio HAL for periph/gpio Jun 28, 2022
@gschorcht gschorcht mentioned this pull request Jun 28, 2022
Merged
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 13, 2022
benpicco
benpicco reviewed Jul 13, 2022
View reviewed changes
cpu/esp32/periph/gpio.c Outdated Show resolved Hide resolved
benpicco
benpicco reviewed Jul 14, 2022
View reviewed changes
cpu/esp32/periph/gpio.c Outdated Show resolved Hide resolved
benpicco
benpicco approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

@gschorcht gschorcht force-pushed the cpu/esp32/periph_hal_esp32_gpio branch from ffa6e9e to 66ceaa4 Compare July 15, 2022 09:03
@benpicco benpicco enabled auto-merge July 15, 2022 09:48
@benpicco benpicco merged commit dd806ce into RIOT-OS:master Jul 15, 2022
@gschorcht gschorcht deleted the cpu/esp32/periph_hal_esp32_gpio branch July 15, 2022 14:10
@gschorcht
Copy link
Contributor Author

@benpicco Thanks for reviewing and merging.

@gschorcht gschorcht mentioned this pull request Jul 18, 2022
Closed
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@smlng smlng Awaiting requested review from smlng

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@maribu maribu Awaiting requested review from maribu

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @benpicco @chrysn