Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32: use ESP-IDF adc/dac HAL for periph/adc and periph/dac #18271

Merged
merged 4 commits into from
Jul 17, 2022
Merged

cpu/esp32: use ESP-IDF adc/dac HAL for periph/adc and periph/dac #18271

merged 4 commits into from
Jul 17, 2022

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jun 28, 2022 •
edited
Loading

Contribution description

This PR is a split-off from PR #17841 and provides:

  • the ESP-IDF adc/dac interface API
  • the changes to use the ESP-IDF adc/dac HAL

Please note: This PR initially provided only the changes for periph/adc. However, since the changes to periph/adc are not possible independently of periph/dac, the changes from PR #18272 had to be included as well. PR #18272 is therefore closed.

This PR depends on PR #18270

Testing procedure

Compile and test with

BOARD=esp32-wroom-32 make -j8 -C tests/periph_adc flash term
BOARD=esp32-wroom-32 make -j8 -C tests/periph_dac flash term

Issues/PRs references

Split-off from PR #17841
~Depends on PR #18270 ~
Prerequisite for PR #18272

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 28, 2022
@gschorcht gschorcht added State: waiting for other PR State: The PR requires another PR to be merged first Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jun 28, 2022
@gschorcht gschorcht requested a review from benpicco June 28, 2022 11:42
@gschorcht gschorcht mentioned this pull request Jun 28, 2022
Closed
@benpicco benpicco requested a review from maribu June 28, 2022 15:18
@gschorcht gschorcht changed the title cpu/esp32: use ESP-IDF adc HAL cpu/esp32: use ESP-IDF adc HAL for periph/adc Jun 28, 2022
@gschorcht gschorcht mentioned this pull request Jul 13, 2022
Merged
@gschorcht gschorcht force-pushed the periph_hal_esp32_adc branch from 9e28fa5 to 0f0d534 Compare July 15, 2022 14:18
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Jul 15, 2022
@gschorcht gschorcht changed the title cpu/esp32: use ESP-IDF adc HAL for periph/adc cpu/esp32: use ESP-IDF adc/dac HAL for periph/adc and periph/dac Jul 16, 2022
@benpicco
Copy link
Contributor

Please squash!

@gschorcht gschorcht force-pushed the periph_hal_esp32_adc branch from a5067a7 to 43d2340 Compare July 17, 2022 15:41
@benpicco benpicco enabled auto-merge July 17, 2022 16:03
@benpicco benpicco merged commit 2c9f338 into RIOT-OS:master Jul 17, 2022
@gschorcht gschorcht deleted the periph_hal_esp32_adc branch July 18, 2022 04:50
@gschorcht gschorcht mentioned this pull request Jul 18, 2022
Closed
@gschorcht
Copy link
Contributor Author

@benpicco Thanks for reviewing and merging.

@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@maribu maribu Awaiting requested review from maribu

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @benpicco @chrysn