pkg/lwip: fix code style #18357
Merged
pkg/lwip: fix code style #18357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly converts switch statements from double indent style to Linux kernel style, as required per the coding convention. From the C compiler perspective, this is a whitespace only change.
maribu
added
Area: network
maribu
commented
Jul 22, 2022
| @@ -96,83 +96,82 @@ err_t lwip_netdev_init(struct netif *netif) | |||
| netif->hostname = "riot"; | |||
| #endif /* LWIP_NETIF_HOSTNAME */ | |||
|
|
|||
| /* XXX: for now assume its Ethernet, since netdev is implemented only by ethernet drivers */ | |||
There was a problem hiding this comment.
Note: This comment is obsolete, below both Ethernet and IEEE 802.15.4 devices are handled differently. There is no "this must be Ethernet" assumption baked in anywhere.
benpicco
approved these changes
Jul 22, 2022
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This mostly converts switch statements from double indent style to Linux kernel style, as required per the coding convention.
From the C compiler perspective, this is a whitespace only change.
Testing procedure
Double checking that changes are indeed white-space only is sufficient. Sadly, the github diff view doesn't really work well here...
Issues/PRs references
I split this out of a yet to be opened PR, so that the PR with actual changes only contains actual changes.