pkg/lwip: use sys/event for handling ISR and bhp #18359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: network
maribu
added
Type: enhancement
maribu
commented
Jul 22, 2022
maribu
removed
the
State: waiting for other PR
|
Rebased to include the whitespace only style fixes. This no longer depends on other PRs. |
2 tasks
yarrick
reviewed
Sep 4, 2022
|
This needs a rebase. |
maribu
changed the title
this is definitely the way to go, thanks! Note that you could also just use |
|
This breaks RX for me (both wired and wireless) when applied on top of 4b87a30 I use |
|
OK, I just rebased to see if the issue is a result of changes to |
|
Hm any news on this? |
I'm still having trouble to get OpenOCD up an running to be able to properly debug the issue on ESP. (I even gave up on using upstream OpenOCD and used openocd-esp32. Unlike upstream OpenOCD this could indeed flash the ESP32 Ethernet Kit via the FTDI bit-banging JTAG interface. But debugging shows the same errors as the upstream version. Did I mention that the state of the software on ESP is extremely frustrating?) |
|
@gschorcht might know more about how to debug esp32 |
|
OK, then let me provide some details on the problem first: Full log output |
I don't have any problem on USEMODULE=esp_jtag PROGRAMMER=openocd BOARD=esp32-wrover-kit make -C tests/shell flash debug
[...]
### Flashing Target ###
Binfile detected, adding ROM base address: 0x00000000
Flashing with IMAGE_OFFSET: 0x00010000
Open On-Chip Debugger v0.11.0-esp32-20211220 (2021-12-20-15:42)
[...]
### Starting Debugging ###
Open On-Chip Debugger v0.11.0-esp32-20211220 (2021-12-20-15:42)
Licensed under GNU GPL v2
For bug reports, read
http://openocd.org/doc/doxygen/bugs.html
Reading symbols from /home/gs/src/RIOT-Xtensa-ESP.esp-idf-4.4/tests/shell/bin/esp32-wrover-kit/tests_shell.elf...
Remote debugging using :3333
0x40000400 in ?? ()Did you use the toolchain and the openocd-esp32 version that are pulled by the install script The following message in your log indicates an incompatibility between the openocd-esp32 and the gdb you are using: |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@jia200x: Could you give this a spin on either the kw2xrf or the mrf24j40 to see if I got the rebase in regard to the bottom half processor correct? Specifically, this now ditches bhp_msg in favor of bhp_event, as there now is an event queue anyway. I sadly have neither radio at hands. |
github-actions
bot
added
Area: tests
benpicco
reviewed
Apr 29, 2024
|
Turns out 6LoWPAN with LWIP is broken anyway (I tested
This works fine with GNRC. Please squash. |
|
Then let's get this in and fix lwIP afterwards. |
yarrick
requested changes
Apr 29, 2024
benpicco
reviewed
Apr 29, 2024
This is directly useful for the two driver using the bhp API, but also other drivers profit from not loosing IRQs. The main selling point is that this paves the way for implementing netdev_driver_t::confirm_send(). Co-authored-by: benpicco <benpicco@googlemail.com> Co-authored-by: Erik Ekman <eekman@google.com>
yarrick
approved these changes
Apr 29, 2024
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is many providing infrastructure for later use, specifically for making use of the
netdev_driver_t::confirm_send(). However, as a positive side-effect, this should prevent lost IRQs. (E.g. consider one netdev saturating the message queue. If now a second netdev wouldalso need its ISR being run, it cannot enqueue its message and the IRQ is lost.)
Testing procedure
The expected failure mode is that no network operation is possible when the ISRs are not being run correctly. I ran
make LWIP=1 BOARD=nucleo-f767zi -C examples/gcoapand could still successfully ping the board.Issues/PRs references
Contains #18357