Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Bring lock files in sync with toml files #18388

Merged

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Aug 1, 2022

The riotmodules dependency was missed in bc8ec6d, and while generally
it does not severly harm builds, it does harm builds riotdocker CI where
branches are switched, which is blocked by dirty files in the checkout.

The riot-wrappers version was missed when what is now 5e75f4b was
rebased onto fdc4e11.

Testing procedure

  • Green CI
  • Building anything (eg `riot-hello-world) locally does not result in a dirty checkout after building. (CI doesn't check for that, but riotdocker CI does).

Issues/PRs references

Unblocks: RIOT-OS/riotdocker#200 (or any other CI update, really)

The riotmodules dependency was missed in bc8ec6d, and while generally
it does not severly harm builds, it does harm builds riotdocker CI where
branches are switched, which is blocked by dirty files in the checkout.

The riot-wrappers version was missed when what is now 5e75f4b was
rebased onto fdc4e11.
@github-actions github-actions bot added Area: examples Area: Example Applications Area: sys Area: System Area: tests Area: tests and testing framework labels Aug 1, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 1, 2022
@chrysn chrysn added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Aug 1, 2022
@benpicco benpicco added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Aug 1, 2022
@benpicco benpicco removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Aug 1, 2022
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 1, 2022
@miri64
Copy link
Member

miri64 commented Aug 1, 2022

Requeued in Murdock queue to give 2022.07 release backport #18354 precedence.

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 2, 2022
@benpicco benpicco enabled auto-merge August 2, 2022 12:50
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 2, 2022
@benpicco benpicco added the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label Aug 2, 2022
@benpicco benpicco merged commit df8d1f3 into RIOT-OS:master Aug 2, 2022
@chrysn chrysn deleted the sync-cargo-lock-files branch August 3, 2022 06:38
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: examples Area: Example Applications Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants