rust: Update cstr dependency #18389
Merged
rust: Update cstr dependency #18389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The riotmodules dependency was missed in bc8ec6d, and while generally it does not severly harm builds, it does harm builds riotdocker CI where branches are switched, which is blocked by dirty files in the checkout. The riot-wrappers version was missed when what is now 5e75f4b was rebased onto fdc4e11.
A change in Rust nightly features broke version 0.2.5 of the `cstr` crate, whose nightly-only features are enabled in some examples. The breakage was quickly fixed upstream in the 0.2.6 version, this updates the locks.
chrysn
added
Impact: minor
chrysn
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: examples
miri64
added
CI: ready for build
|
Requeued in Murdock queue to give 2022.07 release backport #18354 precedence. |
chrysn
added
CI: ready for build
maribu
approved these changes
Aug 20, 2022
|
Backport provided in #18485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
A change in Rust nightly features broke version 0.2.5 of the
cstrcrate, whose nightly-only features are enabled in some examples. The
breakage was quickly fixed upstream in the 0.2.6 version, this updates
the locks.
We could (and should, to minimize this on the long run) also stop using the nightly features -- but given that riot-wrappers are about to switch over to what the standard library now provides anyway, this is the least intrusive fix.
The issue doesn't hit us now because our Rust nightly version is pinned, but it'd hit us as soon as we updated the Rust nightly version in riotdocker.
Testing procedure
Issues/PRs references
Builds on #18388 (they wouldn't merge conflict if I wrote them separately, but it'd still be practically useless rebasing). Look at the second change if that is
Backporting
This only needs backporting if riotdocker updates its nightly version, and after that a point release is to be made. (Because only the automated tests use the latest riotdocker image; regular users would get the riotdocker image that was versioned together with the release AIU).