pkg/lwip: make use of confirm send #18427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: build system
5 tasks
maribu
added
the
State: waiting for other PR
maribu
force-pushed
the
lwip/confirm_send
branch
from
cff692e to
22f9a81
Compare
github-actions
bot
added
Area: drivers
maribu
force-pushed
the
lwip/confirm_send
branch
from
1aaccef to
5d389a5
Compare
The test netdev implements the legacy API, so we need support for that from the upper layer.
Pull in lwip_netdev for netdev integration automatically if there is any netdev to integrate, otherwise don't pull in the module. As a result, applications no longer need to select that module by hand.
maribu
force-pushed
the
lwip/confirm_send
branch
from
5d389a5 to
6e4035d
Compare
maribu
removed
the
State: waiting for other PR
benpicco
reviewed
Apr 30, 2024
|
The lwIP integration has changed a bit since this PR was opened. I will have to adapt a bit. |
maribu
force-pushed
the
lwip/confirm_send
branch
from
6e4035d to
962fca5
Compare
|
Murdock found a bug |
maribu
force-pushed
the
lwip/confirm_send
branch
from
962fca5 to
28f412f
Compare
Thanks, fixed :) |
benpicco
approved these changes
May 6, 2024
|
Thx a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This prepares the lwIP adaption layer to work with netdevs that provide
netdev_driver_t::confirm_send(), allowing to write event based non-blocking netdevs.Testing procedure
This PR does not update any drivers to actually provide
netdev_driver_t::confirm_send().#18428 ports the STM32 Ethernet driver to the new API, so that this PR can be tested there.
Issues/PRs references
Same as #18139 but for lwIP
depends on and includes: